[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a9c98f2a-c5e9-43e3-b77a-0f20eb6cfa98@lunn.ch>
Date: Thu, 27 Feb 2025 17:14:19 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Andrei Botila <andrei.botila@....nxp.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org, s32@....com,
Christophe Lizzi <clizzi@...hat.com>,
Alberto Ruiz <aruizrui@...hat.com>,
Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH 1/3] net: phy: nxp-c45-tja11xx: add support for TJA1121
On Thu, Feb 27, 2025 at 06:00:54PM +0200, Andrei Botila wrote:
> Add naming for TJA1121 since TJA1121 is based on TJA1120 but with
> additional MACsec IP.
> Same applies for TJA1103 which shares the same hardware as TJA1104 with
> the latter having MACsec IP enabled.
>
> Signed-off-by: Andrei Botila <andrei.botila@....nxp.com>
> ---
> drivers/net/phy/Kconfig | 2 +-
> drivers/net/phy/nxp-c45-tja11xx.c | 8 +++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index 41c15a2c2037..d29f9f7fd2e1 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -328,7 +328,7 @@ config NXP_C45_TJA11XX_PHY
> depends on MACSEC || !MACSEC
> help
> Enable support for NXP C45 TJA11XX PHYs.
> - Currently supports the TJA1103, TJA1104 and TJA1120 PHYs.
> + Currently supports the TJA1103, TJA1104, TJA1120 and TJA1121 PHYs.
>
> config NXP_TJA11XX_PHY
> tristate "NXP TJA11xx PHYs support"
> diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
> index 34231b5b9175..244b5889e805 100644
> --- a/drivers/net/phy/nxp-c45-tja11xx.c
> +++ b/drivers/net/phy/nxp-c45-tja11xx.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /* NXP C45 PHY driver
> - * Copyright 2021-2023 NXP
> + * Copyright 2021-2025 NXP
> * Author: Radu Pirea <radu-nicolae.pirea@....nxp.com>
> */
>
> @@ -19,7 +19,9 @@
>
> #include "nxp-c45-tja11xx.h"
>
> +/* Same id: TJA1103, TJA1104 */
> #define PHY_ID_TJA_1103 0x001BB010
> +/* Same id: TJA1120, TJA1121 */
> #define PHY_ID_TJA_1120 0x001BB031
Is there a way to tell them apart? Another register somewhere?
Andrew
Powered by blists - more mailing lists