linux-kernel - Re: [PATCH v2 06/16] x86/mce: Remove __mcheck_cpu_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250227163148.GA785742@yaz-khff2.amd.com>
Date: Thu, 27 Feb 2025 11:31:48 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: x86@...nel.org, Tony Luck <tony.luck@...el.com>,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	Smita.KoralahalliChannabasappa@....com
Subject: Re: [PATCH v2 06/16] x86/mce: Remove __mcheck_cpu_init_early()

On Thu, Feb 27, 2025 at 04:25:00PM +0100, Borislav Petkov wrote:
> On Thu, Feb 13, 2025 at 04:45:55PM +0000, Yazen Ghannam wrote:
> > Also, move __mcheck_cpu_init_generic() after
> > __mcheck_cpu_init_prepare_banks() so that MCA is enabled after the first
> > MCA polling event.
> 
> The reason being?
> 
> Precaution?
> 
> It was this way since forever, why are you moving it now? Any particular
> reason?
> 

1) To read/clear old errors before turning on MCA. The updated
__mcheck_cpu_init_prepare_banks() function does this for the MCi_CTL
registers. This patch does this for the MCG_CTL register too.

2) To ensure that vendor-specific setup is finished beforehand also.

Thanks,
Yazen