linux-kernel - Re: [PATCH v2 0/3] selftests/net: deflake GRO tests and fix return value and output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67c0947690e22_37f92929444@willemb.c.googlers.com.notmuch>
Date: Thu, 27 Feb 2025 11:36:06 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Kevin Krakauer <krakauer@...gle.com>, 
 netdev@...r.kernel.org, 
 linux-kselftest@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 Shuah Khan <shuah@...nel.org>, 
 linux-kernel@...r.kernel.org, 
 Kevin Krakauer <krakauer@...gle.com>
Subject: Re: [PATCH v2 0/3] selftests/net: deflake GRO tests and fix return
 value and output

Kevin Krakauer wrote:
> The GRO selftests can flake and have some confusing behavior. These
> changes make the output and return value of GRO behave as expected, then
> deflake the tests.
> 
> v2:
> - Split into multiple commits.
> - Reduced napi_defer_hard_irqs to 1.
> - Reduced gro_flush_timeout to 100us.
> - Fixed comment that wasn't updated.
> 
> v1: https://lore.kernel.org/netdev/20250218164555.1955400-1-krakauer@google.com/

For next time: add target: [PATCH net-next]

> Kevin Krakauer (3):
>   selftests/net: have `gro.sh -t` return a correct exit code
>   selftests/net: only print passing message in GRO tests when tests pass
>   selftests/net: deflake GRO tests
> 
>  tools/testing/selftests/net/gro.c         | 8 +++++---
>  tools/testing/selftests/net/gro.sh        | 7 ++++---
>  tools/testing/selftests/net/setup_veth.sh | 3 ++-
>  3 files changed, 11 insertions(+), 7 deletions(-)
> 
> -- 
> 2.48.1.658.g4767266eb4-goog
>