| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250227174321.0162a10f@imammedo.users.ipa.redhat.com> Date: Thu, 27 Feb 2025 17:43:21 +0100 From: Igor Mammedov <imammedo@...hat.com> To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org> Cc: "Michael S . Tsirkin" <mst@...hat.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, Shiju Jose <shiju.jose@...wei.com>, qemu-arm@...gnu.org, qemu-devel@...gnu.org, Philippe Mathieu-Daudé <philmd@...aro.org>, Ani Sinha <anisinha@...hat.com>, Cleber Rosa <crosa@...hat.com>, Dongjiu Geng <gengdongjiu1@...il.com>, Eduardo Habkost <eduardo@...kost.net>, Eric Blake <eblake@...hat.com>, John Snow <jsnow@...hat.com>, Marcel Apfelbaum <marcel.apfelbaum@...il.com>, Markus Armbruster <armbru@...hat.com>, Michael Roth <michael.roth@....com>, Paolo Bonzini <pbonzini@...hat.com>, Peter Maydell <peter.maydell@...aro.org>, Shannon Zhao <shannon.zhaosl@...il.com>, Yanan Wang <wangyanan55@...wei.com>, Zhao Liu <zhao1.liu@...el.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v6 00/19] Change ghes to use HEST-based offsets and add support for error inject On Thu, 27 Feb 2025 17:00:38 +0100 Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote: > Now that the ghes preparation patches were merged, let's add support > for error injection. > > On this version, HEST table got added to ACPI tables testing for aarch64 virt. > > There are also some patch reorder to help reviewers to check the changes. > > The code itself is almost identical to v4, with just a few minor nits addressed. checkpatch on my machine still complains 0007-acpi-ghes-Use-HEST-table-offsets-when-preparing-GHES.patch has no obvious style problems and is ready for submission. Checking 0008-acpi-ghes-don-t-hard-code-the-number-of-sources-for-.patch... WARNING: line over 80 characters #170: FILE: hw/acpi/ghes.c:390: + build_ghes_v2_entry(table_data, linker, ¬if_source[i], i, num_sources); total: 0 errors, 1 warnings, 159 lines checked 0008-acpi-ghes-don-t-hard-code-the-number-of-sources-for-.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking 0009-acpi-ghes-add-a-notifier-to-notify-when-error-data-i.patch... total: 0 errors, 0 warnings, 26 lines checked 0009-acpi-ghes-add-a-notifier-to-notify-when-error-data-i.patch has no obvious style problems and is ready for submission. Checking 0010-acpi-generic_event_device-Update-GHES-migration-to-c.patch... total: 0 errors, 0 warnings, 41 lines checked 0010-acpi-generic_event_device-Update-GHES-migration-to-c.patch has no obvious style problems and is ready for submission. Checking 0011-acpi-generic_event_device-add-logic-to-detect-if-HES.patch... total: 0 errors, 0 warnings, 59 lines checked 0011-acpi-generic_event_device-add-logic-to-detect-if-HES.patch has no obvious style problems and is ready for submission. Checking 0012-acpi-generic_event_device-add-an-APEI-error-device.patch... total: 0 errors, 0 warnings, 72 lines checked 0012-acpi-generic_event_device-add-an-APEI-error-device.patch has no obvious style problems and is ready for submission. Checking 0013-tests-acpi-virt-allow-acpi-table-changes-at-DSDT-and.patch... total: 0 errors, 0 warnings, 7 lines checked 0013-tests-acpi-virt-allow-acpi-table-changes-at-DSDT-and.patch has no obvious style problems and is ready for submission. Checking 0014-arm-virt-Wire-up-a-GED-error-device-for-ACPI-GHES.patch... WARNING: line over 80 characters #68: FILE: hw/arm/virt.c:1015: + VirtMachineState *s = container_of(n, VirtMachineState, generic_error_notifier); total: 0 errors, 1 warnings, 44 lines checked 0014-arm-virt-Wire-up-a-GED-error-device-for-ACPI-GHES.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking 0015-qapi-acpi-hest-add-an-interface-to-do-generic-CPER-e.patch... total: 0 errors, 0 warnings, 178 lines checked > --- > v6: > - some minor nits addressed: > - use GPA instead of offset; > - merged two patches; > - fixed a couple of long line coding style issues; > - the HEST/DSDT diff inside a patch was changed to avoid troubles > applying it. > > v5: > - make checkpatch happier; > - HEST table is now tested; > - some changes at HEST spec documentation to align with code changes; > - extra care was taken with regards to git bisectability. > > v4: > - added an extra comment for AcpiGhesState structure; > - patches reordered; > - no functional changes, just code shift between the patches in this series. > > v3: > - addressed more nits; > - hest_add_le now points to the beginning of HEST table; > - removed HEST from tests/data/acpi; > - added an extra patch to not use fw_cfg with virt-10.0 for hw_error_le > > v2: > - address some nits; > - improved ags cleanup patch and removed ags.present field; > - added some missing le*_to_cpu() calls; > - update date at copyright for new files to 2024-2025; > - qmp command changed to: inject-ghes-v2-error ans since updated to 10.0; > - added HEST and DSDT tables after the changes to make check target happy. > (two patches: first one whitelisting such tables; second one removing from > whitelist and updating/adding such tables to tests/data/acpi) > > > > Mauro Carvalho Chehab (19): > tests/acpi: virt: add an empty HEST file > tests/qtest/bios-tables-test: extend to also check HEST table > tests/acpi: virt: update HEST file with its current data > acpi/ghes: Cleanup the code which gets ghes ged state > acpi/ghes: prepare to change the way HEST offsets are calculated > acpi/ghes: add a firmware file with HEST address > acpi/ghes: Use HEST table offsets when preparing GHES records > acpi/ghes: don't hard-code the number of sources for HEST table > acpi/ghes: add a notifier to notify when error data is ready > acpi/generic_event_device: Update GHES migration to cover hest addr > acpi/generic_event_device: add logic to detect if HEST addr is > available > acpi/generic_event_device: add an APEI error device > tests/acpi: virt: allow acpi table changes at DSDT and HEST tables > arm/virt: Wire up a GED error device for ACPI / GHES > qapi/acpi-hest: add an interface to do generic CPER error injection > acpi/generic_event_device.c: enable use_hest_addr for QEMU 10.x > tests/acpi: virt: update HEST and DSDT tables > docs: hest: add new "etc/acpi_table_hest_addr" and update workflow > scripts/ghes_inject: add a script to generate GHES error inject > > MAINTAINERS | 10 + > docs/specs/acpi_hest_ghes.rst | 28 +- > hw/acpi/Kconfig | 5 + > hw/acpi/aml-build.c | 10 + > hw/acpi/generic_event_device.c | 44 ++ > hw/acpi/ghes-stub.c | 7 +- > hw/acpi/ghes.c | 231 ++++-- > hw/acpi/ghes_cper.c | 38 + > hw/acpi/ghes_cper_stub.c | 19 + > hw/acpi/meson.build | 2 + > hw/arm/virt-acpi-build.c | 35 +- > hw/arm/virt.c | 19 +- > hw/core/machine.c | 2 + > include/hw/acpi/acpi_dev_interface.h | 1 + > include/hw/acpi/aml-build.h | 2 + > include/hw/acpi/generic_event_device.h | 1 + > include/hw/acpi/ghes.h | 51 +- > include/hw/arm/virt.h | 2 + > qapi/acpi-hest.json | 35 + > qapi/meson.build | 1 + > qapi/qapi-schema.json | 1 + > scripts/arm_processor_error.py | 476 ++++++++++++ > scripts/ghes_inject.py | 51 ++ > scripts/qmp_helper.py | 703 ++++++++++++++++++ > target/arm/kvm.c | 7 +- > tests/data/acpi/aarch64/virt/DSDT | Bin 5196 -> 5240 bytes > .../data/acpi/aarch64/virt/DSDT.acpihmatvirt | Bin 5282 -> 5326 bytes > tests/data/acpi/aarch64/virt/DSDT.memhp | Bin 6557 -> 6601 bytes > tests/data/acpi/aarch64/virt/DSDT.pxb | Bin 7679 -> 7723 bytes > tests/data/acpi/aarch64/virt/DSDT.topology | Bin 5398 -> 5442 bytes > tests/data/acpi/aarch64/virt/HEST | Bin 0 -> 224 bytes > tests/qtest/bios-tables-test.c | 2 +- > 32 files changed, 1692 insertions(+), 91 deletions(-) > create mode 100644 hw/acpi/ghes_cper.c > create mode 100644 hw/acpi/ghes_cper_stub.c > create mode 100644 qapi/acpi-hest.json > create mode 100644 scripts/arm_processor_error.py > create mode 100755 scripts/ghes_inject.py > create mode 100755 scripts/qmp_helper.py > create mode 100644 tests/data/acpi/aarch64/virt/HEST >
Powered by blists - more mailing lists