linux-kernel - Re: [PATCH v1] x86/insn: Fix linux/unaligned.h include path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8CW4ozmV4OwyXWm@google.com>
Date: Thu, 27 Feb 2025 08:46:26 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>, Josh Poimboeuf <jpoimboe@...nel.org>
Cc: Adrian Hunter <adrian.hunter@...el.com>, Ingo Molnar <mingo@...nel.org>,
	Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v1] x86/insn: Fix linux/unaligned.h include path

Adding Josh and Peter as it's used in objtool as well.

On Wed, Feb 26, 2025 at 04:32:20PM -0800, Namhyung Kim wrote:
> On Tue, Feb 25, 2025 at 11:36:00AM -0800, Ian Rogers wrote:
> > tools/arch/x86/include/linux doesn't exist but building is working by
> > virtue of a -I. Building using bazel this fails. Use angle brackets to
> > include unaligned.h so there isn't an invalid relative include.
> 
> Right, it's using tools/include/linux/unaligned.h.

Josh, are you ok with this?  I can carry this in the perf tools tree if
you don't mind.

Thanks,
Namhyung

> 
> > 
> > Fixes: 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> > ---
> >  tools/arch/x86/lib/insn.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
> > index ab5cdc3337da..e91d4c4e1c16 100644
> > --- a/tools/arch/x86/lib/insn.c
> > +++ b/tools/arch/x86/lib/insn.c
> > @@ -13,7 +13,7 @@
> >  #endif
> >  #include "../include/asm/inat.h" /* __ignore_sync_check__ */
> >  #include "../include/asm/insn.h" /* __ignore_sync_check__ */
> > -#include "../include/linux/unaligned.h" /* __ignore_sync_check__ */
> > +#include <linux/unaligned.h> /* __ignore_sync_check__ */
> >  
> >  #include <linux/errno.h>
> >  #include <linux/kconfig.h>
> > -- 
> > 2.48.1.711.g2feabab25a-goog
> >