linux-kernel - Re: [PATCH v2] pinctrl-tegra: Add config property GPIO mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA1PR12MB94669924DE2F9F7140147C98B7CD2@IA1PR12MB9466.namprd12.prod.outlook.com>
Date: Thu, 27 Feb 2025 16:50:50 +0000
From: Prathamesh Shete <pshete@...dia.com>
To: Thierry Reding <thierry.reding@...il.com>, Linus Walleij
	<linus.walleij@...aro.org>
CC: Jon Hunter <jonathanh@...dia.com>, "peng.fan@....com" <peng.fan@....com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] pinctrl-tegra: Add config property GPIO mode

Hi Linus, 

Can you please help check on this and provide feedback 

Thanks 
Prathamesh. 

On 23/01/25, 2:31 PM, "Thierry Reding" <thierry.reding@...il.com> wrote: 
On Fri, Dec 20, 2024 at 02:51:43PM +0100, Linus Walleij wrote: 

> Hi Prathamesh, 

> 

> thanks for your patch! 

> 

> a question here: 

> 

> On Tue, Dec 17, 2024 at 4:33 PM Prathamesh Shete <pshete@...dia.com <mailto:pshete@...dia.com>> wrote: 

> 

> > The SFIO/GPIO select bit is a crucial part of Tegra's pin multiplexing 

> > system: 

> > - When set to 1, the pin operates in SFIO mode, controlled by the 

> > pin's assigned special function. 

> > - When set to 0, the pin operates as a general-purpose GPIO. 

> > 

> > This SFIO/GPIO select bit that is set for a given pin is not displayed, 

> > adding the support to retrieve this information from the 

> > pinmux set for each pin. 

> > 

> > Signed-off-by: Prathamesh Shete <pshete@...dia.com <mailto:pshete@...dia.com>> 

> 

> If the description is correct, why is this bit not unconditionally 

> set in 

> tegra_pinctrl_gpio_request_enable() 

> and unconditionally cleared in 

> tegra_pinctrl_gpio_disable_free() 

> ? 



Sorry for the late reply. This bit is already being set during 

.gpio_request_enable() and .gpio_disable_free(). My understanding is 

that this patch is primarily for making this available in debugfs. I 

suppose we could make that clearer by not making this part of the 

standard pinconfig options, but rather put it into a "read-only" set 

configs? 



Thierry 





Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (9730 bytes)