linux-kernel - Re: [PATCH 2/2] iommu: apple-dart: Allow mismatched bypass support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8Cae58jLqcGwF8S@blossom>
Date: Thu, 27 Feb 2025 12:01:47 -0500
From: Alyssa Rosenzweig <alyssa@...enzweig.io>
To: fnkl.kernel@...il.com
Cc: Sven Peter <sven@...npeter.dev>, Janne Grunau <j@...nau.net>,
	Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
	Robin Murphy <robin.murphy@....com>, asahi@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Hector Martin <marcan@...can.st>
Subject: Re: [PATCH 2/2] iommu: apple-dart: Allow mismatched bypass support

> +		/* Will be ANDed with DART capabilities */
> +		cfg->supports_bypass = true;
...
> +	if (!dart->supports_bypass)
> +		cfg->supports_bypass = false;

Probably better to write

   cfg->supports_bypass &= dart->supports_bypass;

To match what's in the comment!