linux-kernel - Re: [PATCH 3/3] ACPI: platform_profile: Do not hide options missing in secondary handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202502280150.DkqQsO8C-lkp@intel.com>
Date: Fri, 28 Feb 2025 01:48:50 +0800
From: kernel test robot <lkp@...el.com>
To: Antheas Kapenekakis <lkml@...heas.dev>, mario.limonciello@....com,
	mpearson-lenovo@...ebb.ca
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	ilpo.jarvinen@...ux.intel.com, lenb@...nel.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org, rafael@...nel.org,
	hdegoede@...hat.com, me@...egospodneti.ch,
	Antheas Kapenekakis <lkml@...heas.dev>
Subject: Re: [PATCH 3/3] ACPI: platform_profile: Do not hide options missing
 in secondary handlers

Hi Antheas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.14-rc4 next-20250227]
[cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Antheas-Kapenekakis/ACPI-platform_profile-Add-support-for-secondary-handlers/20250225-035455
base:   linus/master
patch link:    https://lore.kernel.org/r/20250224195059.10185-4-lkml%40antheas.dev
patch subject: [PATCH 3/3] ACPI: platform_profile: Do not hide options missing in secondary handlers
config: i386-buildonly-randconfig-003-20250227 (https://download.01.org/0day-ci/archive/20250228/202502280150.DkqQsO8C-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250228/202502280150.DkqQsO8C-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502280150.DkqQsO8C-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/acpi/platform_profile.c:248: warning: Function parameter or struct member 'secondary' not described in '_aggregate_choices'


vim +248 drivers/acpi/platform_profile.c

77be5cacb2c2d8 Mario Limonciello   2024-12-05  239  
06ec24388f1de6 Mario Limonciello   2024-12-05  240  /**
06ec24388f1de6 Mario Limonciello   2024-12-05  241   * _aggregate_choices - Aggregate the available profile choices
06ec24388f1de6 Mario Limonciello   2024-12-05  242   * @dev: The device
06ec24388f1de6 Mario Limonciello   2024-12-05  243   * @data: The available profile choices
06ec24388f1de6 Mario Limonciello   2024-12-05  244   *
06ec24388f1de6 Mario Limonciello   2024-12-05  245   * Return: 0 on success, -errno on failure
06ec24388f1de6 Mario Limonciello   2024-12-05  246   */
724b0dfe3faddb Antheas Kapenekakis 2025-02-24  247  static int _aggregate_choices(struct device *dev, void *data, bool secondary)
06ec24388f1de6 Mario Limonciello   2024-12-05 @248  {
06ec24388f1de6 Mario Limonciello   2024-12-05  249  	struct platform_profile_handler *handler;
06ec24388f1de6 Mario Limonciello   2024-12-05  250  	unsigned long *aggregate = data;
06ec24388f1de6 Mario Limonciello   2024-12-05  251  
06ec24388f1de6 Mario Limonciello   2024-12-05  252  	lockdep_assert_held(&profile_lock);
d960f14800b581 Kurt Borja          2025-01-15  253  	handler = to_pprof_handler(dev);
724b0dfe3faddb Antheas Kapenekakis 2025-02-24  254  
724b0dfe3faddb Antheas Kapenekakis 2025-02-24  255  	if (handler->ops->secondary != secondary)
724b0dfe3faddb Antheas Kapenekakis 2025-02-24  256  		return 0;
724b0dfe3faddb Antheas Kapenekakis 2025-02-24  257  
06ec24388f1de6 Mario Limonciello   2024-12-05  258  	if (test_bit(PLATFORM_PROFILE_LAST, aggregate))
06ec24388f1de6 Mario Limonciello   2024-12-05  259  		bitmap_copy(aggregate, handler->choices, PLATFORM_PROFILE_LAST);
724b0dfe3faddb Antheas Kapenekakis 2025-02-24  260  	else if (handler->ops->secondary)
724b0dfe3faddb Antheas Kapenekakis 2025-02-24  261  		bitmap_or(aggregate, handler->choices, aggregate, PLATFORM_PROFILE_LAST);
06ec24388f1de6 Mario Limonciello   2024-12-05  262  	else
06ec24388f1de6 Mario Limonciello   2024-12-05  263  		bitmap_and(aggregate, handler->choices, aggregate, PLATFORM_PROFILE_LAST);
06ec24388f1de6 Mario Limonciello   2024-12-05  264  
06ec24388f1de6 Mario Limonciello   2024-12-05  265  	return 0;
06ec24388f1de6 Mario Limonciello   2024-12-05  266  }
06ec24388f1de6 Mario Limonciello   2024-12-05  267  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki