linux-kernel - Re: [PATCH] net: qed: make 'qed_ll2_ops_pass' as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250227183314.GJ1615191@kernel.org>
Date: Thu, 27 Feb 2025 18:33:14 +0000
From: Simon Horman <horms@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Manish Chopra <manishc@...vell.com>, Arnd Bergmann <arnd@...db.de>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] net: qed: make 'qed_ll2_ops_pass' as __maybe_unused

+ Andrew, Dave, Eric, Jakub, and Paolo

On Tue, Feb 25, 2025 at 09:09:23PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> gcc warns about unused const variables even in header files when
> building with W=1:
> 
>     In file included from include/linux/qed/qed_rdma_if.h:14,
>                      from drivers/net/ethernet/qlogic/qed/qed_rdma.h:16,
>                      from drivers/net/ethernet/qlogic/qed/qed_cxt.c:23:
>     include/linux/qed/qed_ll2_if.h:270:33: error: 'qed_ll2_ops_pass' defined but not used [-Werror=unused-const-variable=]
>       270 | static const struct qed_ll2_ops qed_ll2_ops_pass = {
> 
> This one is intentional, so mark it as __maybe_unused to it can be
> included from a file that doesn't use this variable.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Simon Horman <horms@...nel.org>
Tested-by: Simon Horman <horms@...nel.org> # build-tested

This is marked as being not a local patch in netdev patchwork.
That doesn't seem right to me and perhaps this will address that.

pw-bot: under-review

Possibly this because is because while qed_rdma_if.h is
included in the QLOGIC QL4xxx ETHERNET DRIVER section
of MAINTAINERS, it is not included in the NETWORKING DRIVERS section.

I will plan to submit a patch to address that.