linux-kernel - Re: [PATCH v4 1/2] iio: filter: admv8818: fix range calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8DXIGxA5mJK0oPN@65YTFL3.secure.tethers.com>
Date: Thu, 27 Feb 2025 16:20:32 -0500
From: Sam Winchenbach <sam.winchenbach@...mepointer.org>
To: kernel test robot <lkp@...el.com>
Cc: linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	oe-kbuild-all@...ts.linux.dev, lars@...afoo.de,
	Michael.Hennerich@...log.com, antoniu.miclaus@...log.com,
	jic23@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v4 1/2] iio: filter: admv8818: fix range calculation

On Fri, Feb 28, 2025 at 04:23:44AM +0800, kernel test robot wrote:
> Hi Sam,
> 
> kernel test robot noticed the following build errors:
> 
--- snip ---
> >> drivers/iio/filter/admv8818.c:304:34: error: use of undeclared identifier 'lfp_corner_target'; did you mean 'lpf_corner_target'?
>      304 |         ret = __admv8818_lpf_select(st, lfp_corner_target);
>          |                                         ^~~~~~~~~~~~~~~~~
>          |                                         lpf_corner_target
>    drivers/iio/filter/admv8818.c:283:25: note: 'lpf_corner_target' declared here
>      283 |         u64 hpf_corner_target, lpf_corner_target;
>          |                                ^
>    12 warnings and 1 error generated.

Well this is embarassing. I must have have had a fat-finger accident when
inspecting the result of applying the patch to torvalds/master.

I will fix this in v5 once we come to a concensus on the DTS changes.

--- snip ---
>    303	
>  > 304		ret = __admv8818_lpf_select(st, lfp_corner_target);
>    305	exit:
>    306		mutex_unlock(&st->lock);
>    307		return ret;
>    308	}
>    309	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki