linux-kernel - Re: [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8Dmz_UPfR-WS8LI@x130>
Date: Thu, 27 Feb 2025 14:27:27 -0800
From: Saeed Mahameed <saeed@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Saeed Mahameed <saeedm@...dia.com>,
	Leon Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v3][next] net/mlx5e: Avoid a hundred
 -Wflex-array-member-not-at-end warnings

On 26 Feb 17:25, Jakub Kicinski wrote:
>On Wed, 26 Feb 2025 10:49:35 -0800 Saeed Mahameed wrote:
>> On 26 Feb 13:47, Gustavo A. R. Silva wrote:
>> >-struct mlx5e_umr_wqe {
>> >+struct mlx5e_umr_wqe_hdr {
>> > 	struct mlx5_wqe_ctrl_seg       ctrl;
>> > 	struct mlx5_wqe_umr_ctrl_seg   uctrl;
>> > 	struct mlx5_mkey_seg           mkc;
>> >+};
>> >+
>> >+struct mlx5e_umr_wqe {
>> >+	struct mlx5e_umr_wqe_hdr hdr;
>>
>> You missed or ignored my comment on v0, anyway:
>>
>> Can we have struct mlx5e_umr_wq_hdr defined anonymously within
>> mlx5e_umr_wqe? Let's avoid namespace pollution.
>
>It's also used in struct mlx5e_rq, I don't think it can be anonymous?

Yep, I see now, Thanks!.