linux-kernel - Re: [PATCH v2] zswap: do not crash the kernel on decompression failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKEwX=NsHtTpOV+LSh2GHCMhF9GSKFhyXFNOTifKPk17UiN-ag@mail.gmail.com>
Date: Thu, 27 Feb 2025 14:35:04 -0800
From: Nhat Pham <nphamcs@...il.com>
To: Johannes Weiner <hannes@...xchg.org>
Cc: Yosry Ahmed <yosry.ahmed@...ux.dev>, akpm@...ux-foundation.org, 
	chengming.zhou@...ux.dev, linux-mm@...ck.org, kernel-team@...a.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] zswap: do not crash the kernel on decompression failure

On Thu, Feb 27, 2025 at 8:05 AM Johannes Weiner <hannes@...xchg.org> wrote:
>
> On Thu, Feb 27, 2025 at 07:29:45AM +0000, Yosry Ahmed wrote:

I like this actually,

> I'd actually rather push those down into zeromap and zswap as well to
> follow that pattern more closely:
>
> diff --git a/mm/page_io.c b/mm/page_io.c
> index 9b983de351f9..1fb5ce1884bd 100644
> --- a/mm/page_io.c
> +++ b/mm/page_io.c
> @@ -538,6 +538,7 @@ static bool swap_read_folio_zeromap(struct folio *folio)
>
>         folio_zero_range(folio, 0, folio_size(folio));
>         folio_mark_uptodate(folio);

There should be another folio_unlock() above I think.

> +       folio_unlock(folio);
>         return true;
>  }
>