linux-kernel - Re: [PATCH v2 1/2] ARM: substitute OVERLAY description in linker script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdau2cYA=+UOprqj7n9HCf5xQqpZWxnX1gMmuntr95E+fw@mail.gmail.com>
Date: Fri, 28 Feb 2025 00:22:37 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Christian Eggers <ceggers@...i.de>
Cc: Russell King <linux@...linux.org.uk>, Yuntao Liu <liuyuntao12@...wei.com>, 
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Arnd Bergmann <arnd@...db.de>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Catalin Marinas <catalin.marinas@....com>, 
	Nathan Chancellor <nathan@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2 1/2] ARM: substitute OVERLAY description in linker script

On Mon, Feb 24, 2025 at 1:54 PM Christian Eggers <ceggers@...i.de> wrote:

> If linker garbage collection is active, we must ensure that the vectors
> are not removed during linking (by using the KEEP keyword).  But it
> seems that the LLD linker doesn't support using the KEEP() keyword
> within an overlay description.
>
> The GNU linker manual shows an alternative way to accomplish the same
> result without using the overlay statement:
>
> https://sourceware.org/binutils/docs/ld/Overlay-Description.html
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502222158.UhwuvDZv-lkp@intel.com/
> Signed-off-by: Christian Eggers <ceggers@...i.de>

Looks right to me:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij