linux-kernel - Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502280748.oNKTNuMK-lkp@intel.com>
Date: Fri, 28 Feb 2025 07:59:00 +0800
From: kernel test robot <lkp@...el.com>
To: Aditya Garg <gargaditya08@...e.com>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>,
	"tzimmermann@...e.de" <tzimmermann@...e.de>,
	"airlied@...il.com" <airlied@...il.com>,
	"simona@...ll.ch" <simona@...ll.ch>,
	"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>
Cc: oe-kbuild-all@...ts.linux.dev, Kerem Karabay <kekrby@...il.com>,
	Atharva Tiwari <evepolonium@...il.com>,
	Aun-Ali Zaidi <admin@...eit.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86
 Macs

Hi Aditya,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.14-rc4 next-20250227]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aditya-Garg/drm-format-helper-Add-conversion-from-XRGB8888-to-BGR888/20250224-214352
base:   linus/master
patch link:    https://lore.kernel.org/r/844C1D39-4891-4DC2-8458-F46FA1B59FA0%40live.com
patch subject: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20250228/202502280748.oNKTNuMK-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250228/202502280748.oNKTNuMK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502280748.oNKTNuMK-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/tiny/appletbdrm.c: In function 'appletbdrm_primary_plane_duplicate_state':
>> drivers/gpu/drm/tiny/appletbdrm.c:524:40: warning: variable 'old_appletbdrm_state' set but not used [-Wunused-but-set-variable]
     524 |         struct appletbdrm_plane_state *old_appletbdrm_state;
         |                                        ^~~~~~~~~~~~~~~~~~~~


vim +/old_appletbdrm_state +524 drivers/gpu/drm/tiny/appletbdrm.c

   520	
   521	static struct drm_plane_state *appletbdrm_primary_plane_duplicate_state(struct drm_plane *plane)
   522	{
   523		struct drm_shadow_plane_state *new_shadow_plane_state;
 > 524		struct appletbdrm_plane_state *old_appletbdrm_state;
   525		struct appletbdrm_plane_state *appletbdrm_state;
   526	
   527		if (WARN_ON(!plane->state))
   528			return NULL;
   529	
   530		old_appletbdrm_state = to_appletbdrm_plane_state(plane->state);
   531		appletbdrm_state = kzalloc(sizeof(*appletbdrm_state), GFP_KERNEL);
   532		if (!appletbdrm_state)
   533			return NULL;
   534	
   535		/* Request and response are not duplicated and are allocated in .atomic_check */
   536		appletbdrm_state->request = NULL;
   537		appletbdrm_state->response = NULL;
   538	
   539		appletbdrm_state->request_size = 0;
   540		appletbdrm_state->frames_size = 0;
   541	
   542		new_shadow_plane_state = &appletbdrm_state->base;
   543	
   544		__drm_gem_duplicate_shadow_plane_state(plane, new_shadow_plane_state);
   545	
   546		return &new_shadow_plane_state->base;
   547	}
   548	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki