linux-kernel - Re: [PATCH v3 net-next] dpll: Add an assertion to check freq_supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34b2c92f-e879-4a9e-beb6-c6786bd59c9d@intel.com>
Date: Thu, 27 Feb 2025 06:21:08 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Jiasheng Jiang <jiashengjiangcool@...il.com>
CC: <arkadiusz.kubalewski@...el.com>, <jiri@...nulli.us>,
	<davem@...emloft.net>, <jan.glaza@...el.com>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <stable@...r.kernel.org>,
	<vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH v3 net-next] dpll: Add an assertion to check
 freq_supported_num

On 2/26/25 20:37, Jiasheng Jiang wrote:
> Since the driver is broken in the case that src->freq_supported is not
> NULL but src->freq_supported_num is 0, add an assertion for it.
> 
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>
> ---
> Changelog:
> 
> v2 -> v3:

please post next revision as a separate thread instead of
in-reply-to the previous one

please also do wait a minimum of 24h prior to submitting a new
revision

> 
> 1. Add "net-next" to the subject.
> 2. Remove the "Fixes" tag and "Cc: stable".
> 3. Replace BUG_ON with WARN_ON.
> 
> v1 -> v2:
> 
> 1. Replace the check with an assertion.
> ---
>   drivers/dpll/dpll_core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c
> index 32019dc33cca..0927eddbd417 100644
> --- a/drivers/dpll/dpll_core.c
> +++ b/drivers/dpll/dpll_core.c
> @@ -443,8 +443,9 @@ static void dpll_pin_prop_free(struct dpll_pin_properties *prop)
>   static int dpll_pin_prop_dup(const struct dpll_pin_properties *src,
>   			     struct dpll_pin_properties *dst)
>   {
> +	WARN_ON(src->freq_supported && !src->freq_supported_num);

Jiri has asked for an early return too

>   	memcpy(dst, src, sizeof(*dst));
> -	if (src->freq_supported && src->freq_supported_num) {
> +	if (src->freq_supported) {
>   		size_t freq_size = src->freq_supported_num *
>   				   sizeof(*src->freq_supported);
>   		dst->freq_supported = kmemdup(src->freq_supported,