linux-kernel - RE: [PATCH v5 1/3] PCI: xilinx-cpm: Fix IRQ domain leak in error path of probe.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SN7PR12MB720174213D8DD5FF5F5E20708BCD2@SN7PR12MB7201.namprd12.prod.outlook.com>
Date: Thu, 27 Feb 2025 05:52:58 +0000
From: "Havalige, Thippeswamy" <thippeswamy.havalige@....com>
To: "Havalige, Thippeswamy" <thippeswamy.havalige@....com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "lpieralisi@...nel.org"
	<lpieralisi@...nel.org>, "kw@...ux.com" <kw@...ux.com>,
	"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>
CC: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Simek,
 Michal" <michal.simek@....com>, "Gogada, Bharat Kumar"
	<bharat.kumar.gogada@....com>
Subject: RE: [PATCH v5 1/3] PCI: xilinx-cpm: Fix IRQ domain leak in error path
 of probe.

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Manivannan/Bjorn,

Can you please provide update on this patch.

Regards,
Thippeswamy H

> -----Original Message-----
> From: Thippeswamy Havalige <thippeswamy.havalige@....com>
> Sent: Monday, February 24, 2025 9:20 PM
> To: bhelgaas@...gle.com; lpieralisi@...nel.org; kw@...ux.com;
> manivannan.sadhasivam@...aro.org; robh@...nel.org; krzk+dt@...nel.org;
> conor+dt@...nel.org
> Cc: linux-pci@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; Simek, Michal <michal.simek@....com>; Gogada,
> Bharat Kumar <bharat.kumar.gogada@....com>; Havalige, Thippeswamy
> <thippeswamy.havalige@....com>
> Subject: [PATCH v5 1/3] PCI: xilinx-cpm: Fix IRQ domain leak in error path of
> probe.
>
> The IRQ domain allocated for the PCIe controller is not freed if
> resource_list_first_type returns NULL, leading to a resource leak.
>
> This fix ensures properly cleaning up the allocated IRQ domain in the error
> path.
>
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@....com>
> ---
>  drivers/pci/controller/pcie-xilinx-cpm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-xilinx-cpm.c
> b/drivers/pci/controller/pcie-xilinx-cpm.c
> index 81e8bfae53d0..660b12fc4631 100644
> --- a/drivers/pci/controller/pcie-xilinx-cpm.c
> +++ b/drivers/pci/controller/pcie-xilinx-cpm.c
> @@ -583,8 +583,10 @@ static int xilinx_cpm_pcie_probe(struct
> platform_device *pdev)
>               return err;
>
>       bus = resource_list_first_type(&bridge->windows, IORESOURCE_BUS);
> -     if (!bus)
> +     if (!bus) {
> +             xilinx_cpm_free_irq_domains(port);
>               return -ENODEV;
> +     }
>
>       port->variant = of_device_get_match_data(dev);
>
> --
> 2.43.0