linux-kernel - Re: [PATCH v1 1/4] pps: generators: tio: split pps_gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8AR1Qq0F_e8PjBl@surfacebook.localdomain>
Date: Thu, 27 Feb 2025 09:18:45 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Raag Jadav <raag.jadav@...el.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, lee@...nel.org,
	giometti@...eenne.com, gregkh@...uxfoundation.org,
	raymond.tan@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/4] pps: generators: tio: split pps_gen_tio.h

Thu, Feb 27, 2025 at 07:08:43AM +0200, Raag Jadav kirjoitti:
> On Wed, Feb 26, 2025 at 02:45:26PM +0200, Andy Shevchenko wrote:
> > On Wed, Feb 26, 2025 at 11:45:24AM +0530, Raag Jadav wrote:

...

> > > +#include <linux/bitfield.h>
> > > +#include <linux/bits.h>
> > > +#include <linux/hrtimer.h>
> > > +#include <linux/pps_gen_kernel.h>
> > > +#include <linux/spinlock_types.h>
> > 
> > This missing time.h and types.h.
> 
> Aren't they guaranteed by hrtimer.h and spinlock_types.h?

Nope, why? HR timer is only for HR timer specific definitions and APIs, how
does they are related?

time.h due to NSEC_PER_USEC (or what was there?) and types.h due to u32.

-- 
With Best Regards,
Andy Shevchenko