linux-kernel - Re: [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502271546.WRb9VN4H-lkp@intel.com>
Date: Thu, 27 Feb 2025 15:48:12 +0800
From: kernel test robot <lkp@...el.com>
To: Gabriele Monaco <gmonaco@...hat.com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	"Paul E. McKenney" <paulmck@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev,
	Linux Memory Management List <linux-mm@...ck.org>,
	Gabriele Monaco <gmonaco@...hat.com>,
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct

Hi Gabriele,

kernel test robot noticed the following build errors:

[auto build test ERROR on ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7]

url:    https://github.com/intel-lab-lkp/linux/commits/Gabriele-Monaco/sched-Add-prev_sum_exec_runtime-support-for-RT-DL-and-SCX-classes/20250226-150508
base:   ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7
patch link:    https://lore.kernel.org/r/20250226070202.95062-3-gmonaco%40redhat.com
patch subject: [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct
config: arc-randconfig-002-20250227 (https://download.01.org/0day-ci/archive/20250227/202502271546.WRb9VN4H-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250227/202502271546.WRb9VN4H-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502271546.WRb9VN4H-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/sched/core.c: In function 'sched_tick':
>> kernel/sched/core.c:5667:21: error: 'RSEQ_UNPREEMPTED_THRESHOLD' undeclared (first use in this function)
    5667 |         if (rtime > RSEQ_UNPREEMPTED_THRESHOLD)
         |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/core.c:5667:21: note: each undeclared identifier is reported only once for each function it appears in


vim +/RSEQ_UNPREEMPTED_THRESHOLD +5667 kernel/sched/core.c

  5629	
  5630	/*
  5631	 * This function gets called by the timer code, with HZ frequency.
  5632	 * We call it with interrupts disabled.
  5633	 */
  5634	void sched_tick(void)
  5635	{
  5636		int cpu = smp_processor_id();
  5637		struct rq *rq = cpu_rq(cpu);
  5638		/* accounting goes to the donor task */
  5639		struct task_struct *donor;
  5640		struct rq_flags rf;
  5641		unsigned long hw_pressure;
  5642		u64 resched_latency, rtime;
  5643	
  5644		if (housekeeping_cpu(cpu, HK_TYPE_KERNEL_NOISE))
  5645			arch_scale_freq_tick();
  5646	
  5647		sched_clock_tick();
  5648	
  5649		rq_lock(rq, &rf);
  5650		donor = rq->donor;
  5651		rtime = donor->se.sum_exec_runtime - donor->se.prev_sum_exec_runtime;
  5652	
  5653		psi_account_irqtime(rq, donor, NULL);
  5654	
  5655		update_rq_clock(rq);
  5656		hw_pressure = arch_scale_hw_pressure(cpu_of(rq));
  5657		update_hw_load_avg(rq_clock_task(rq), rq, hw_pressure);
  5658	
  5659		if (dynamic_preempt_lazy() && tif_test_bit(TIF_NEED_RESCHED_LAZY))
  5660			resched_curr(rq);
  5661	
  5662		donor->sched_class->task_tick(rq, donor, 0);
  5663		if (sched_feat(LATENCY_WARN))
  5664			resched_latency = cpu_resched_latency(rq);
  5665		calc_global_load_tick(rq);
  5666		sched_core_tick(rq);
> 5667		if (rtime > RSEQ_UNPREEMPTED_THRESHOLD)
  5668			rseq_preempt(donor);
  5669		scx_tick(rq);
  5670	
  5671		rq_unlock(rq, &rf);
  5672	
  5673		if (sched_feat(LATENCY_WARN) && resched_latency)
  5674			resched_latency_warn(cpu, resched_latency);
  5675	
  5676		perf_event_task_tick();
  5677	
  5678		if (donor->flags & PF_WQ_WORKER)
  5679			wq_worker_tick(donor);
  5680	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki