linux-kernel - Re: [PATCH v2] scsi: stop judging after finding a VPD page expected to be processed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd7a4016-d922-47a0-a912-1a2928b8298a@oracle.com>
Date: Thu, 27 Feb 2025 07:55:07 +0000
From: John Garry <john.g.garry@...cle.com>
To: Chaohai Chen <wdhh6@...yun.com>, James.Bottomley@...senPartnership.com,
        martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        bvanassche@....org
Subject: Re: [PATCH v2] scsi: stop judging after finding a VPD page expected
 to be processed.

On 27/02/2025 06:06, Chaohai Chen wrote:
> +#define SCSI_BUILD_BUG_ON(cond) (sizeof(char[1 - 2 * !!(cond)]) - sizeof(char))
> +
> +#define VPD_PAGE_INFO(vpd_page)							\
> +	{ 0x##vpd_page, offsetof(struct scsi_device, vpd_pg##vpd_page) + \
> +		SCSI_BUILD_BUG_ON(!__same_type(&((struct scsi_device *)NULL)->vpd_pg##vpd_page, \
> +				struct scsi_vpd __rcu **))} \
> +
>   #define	to_scsi_device(d)	\

That's unreadable....