linux-kernel - Re: [PATCH V3 5/5] mm: Rename GENERIC_PTDUMP and PTDUMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39986b7d-7a82-4f28-9289-5620a2bec2b5@arm.com>
Date: Thu, 27 Feb 2025 05:36:25 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Catalin Marinas <catalin.marinas@....com>
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
 Mark Rutland <mark.rutland@....com>,
 Christophe Leroy <christophe.leroy@...roup.eu>, kvmarm@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
 Will Deacon <will@...nel.org>, Jonathan Corbet <corbet@....net>,
 Marc Zyngier <maz@...nel.org>, Michael Ellerman <mpe@...erman.id.au>,
 Nicholas Piggin <npiggin@...il.com>, Paul Walmsley
 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
 Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH V3 5/5] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE

 

On 2/27/25 01:23, Catalin Marinas wrote:
> On Wed, Feb 26, 2025 at 05:54:04PM +0530, Anshuman Khandual wrote:
>> diff --git a/arch/arm64/include/asm/ptdump.h b/arch/arm64/include/asm/ptdump.h
>> index 6cf4aae05219..b2931d1ae0fb 100644
>> --- a/arch/arm64/include/asm/ptdump.h
>> +++ b/arch/arm64/include/asm/ptdump.h
>> @@ -7,7 +7,7 @@
>>  
>>  #include <linux/ptdump.h>
>>  
>> -#ifdef CONFIG_PTDUMP_CORE
>> +#ifdef CONFIG_PTDUMP
> 
> Do we need this #ifdef at all? I haven't tried but usually, if the
> feature is not enabled, the header file on its own should be harmless.

With or without the #ifdef CONFIG_PTDUMP in place here, this does not cause
any build warnings even without CONFIG_PTDUMP enabled. But dropping #ifdef
while renaming the config option itself, might have caused unrelated code
churn. So probably if required we could drop this later on.

> 
> For arm64:
> 
> Acked-by: Catalin Marinas <catalin.marinas@....com>