linux-kernel - Re: [PATCH v2] usb: xhci: lack of clearing xHC resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202502271523.jt3l4VVu-lkp@intel.com>
Date: Thu, 27 Feb 2025 16:10:52 +0800
From: kernel test robot <lkp@...el.com>
To: Pawel Laszczak <pawell@...ence.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc: oe-kbuild-all@...ts.linux.dev,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>,
	"krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
	"christophe.jaillet@...adoo.fr" <christophe.jaillet@...adoo.fr>,
	"javier.carrasco@...fvision.net" <javier.carrasco@...fvision.net>,
	"make_ruc2021@....com" <make_ruc2021@....com>,
	"peter.chen@....com" <peter.chen@....com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Pawel Eichler <peichler@...ence.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v2] usb: xhci: lack of clearing xHC resources

Hi Pawel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.14-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Pawel-Laszczak/usb-xhci-lack-of-clearing-xHC-resources/20250226-153837
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/PH7PR07MB95385E2766D01F3741D418ABDDC22%40PH7PR07MB9538.namprd07.prod.outlook.com
patch subject: [PATCH v2] usb: xhci: lack of clearing xHC resources
config: i386-buildonly-randconfig-001-20250227 (https://download.01.org/0day-ci/archive/20250227/202502271523.jt3l4VVu-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250227/202502271523.jt3l4VVu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502271523.jt3l4VVu-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/usb/core/hub.c:6084: warning: Function parameter or struct member 'udev' not described in 'hub_hc_release_resources'
>> drivers/usb/core/hub.c:6084: warning: Excess function parameter 'pdev' description in 'hub_hc_release_resources'


vim +6084 drivers/usb/core/hub.c

  6067	
  6068	/**
  6069	 * hub_hc_release_resources - clear resources used by host controller
  6070	 * @pdev: pointer to device being released
  6071	 *
  6072	 * Context: task context, might sleep
  6073	 *
  6074	 * Function releases the host controller resources in correct order before
  6075	 * making any operation on resuming usb device. The host controller resources
  6076	 * allocated for devices in tree should be released starting from the last
  6077	 * usb device in tree toward the root hub. This function is used only during
  6078	 * resuming device when usb device require reinitialization - that is, when
  6079	 * flag udev->reset_resume is set.
  6080	 *
  6081	 * This call is synchronous, and may not be used in an interrupt context.
  6082	 */
  6083	static void hub_hc_release_resources(struct usb_device *udev)
> 6084	{
  6085		struct usb_hub *hub = usb_hub_to_struct_hub(udev);
  6086		struct usb_hcd *hcd = bus_to_hcd(udev->bus);
  6087		int i;
  6088	
  6089		/* Release up resources for all children before this device */
  6090		for (i = 0; i < udev->maxchild; i++)
  6091			if (hub->ports[i]->child)
  6092				hub_hc_release_resources(hub->ports[i]->child);
  6093	
  6094		if (hcd->driver->reset_device)
  6095			hcd->driver->reset_device(hcd, udev);
  6096	}
  6097	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki