linux-kernel - Re: [GIT PULL] KVM changes for Linux 6.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250227-teigtaschen-junitag-4dfb547792b4@brauner>
Date: Thu, 27 Feb 2025 09:15:01 +0100
From: Christian Brauner <brauner@...nel.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, 
	Linus Torvalds <torvalds@...ux-foundation.org>, "Michael S. Tsirkin" <mst@...hat.com>, 
	"Eric W. Biederman" <ebiederm@...ssion.com>, linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [GIT PULL] KVM changes for Linux 6.14

On Wed, Feb 26, 2025 at 08:03:23PM +0100, Oleg Nesterov wrote:
> Sorry, didn't have time to actually read this patch, but after a quick
> glance...
> 
> On 02/26, Christian Brauner wrote:
> >
> > @@ -3949,7 +3955,7 @@ static int proc_task_readdir(struct file *file, struct dir_context *ctx)
> >  	tid = (int)(intptr_t)file->private_data;
> >  	file->private_data = NULL;
> >  	for (task = first_tid(proc_pid(inode), tid, ctx->pos - 2, ns);
> > -	     task;
> > +	     task && !(task->flags & PF_USER_WORKER);
> 
> unless I am totally confused this looks "obviously wrong".
> 
> proc_task_readdir() should not stop if it sees a PF_USER_WORKER task, this
> check should go into first_tid/next_tid.

It's really a draft as I said. I'm more interested in whether this is a
viable idea to separate kernel spawned workers into /proc/<pid>/worker
and not show them in /proc/<pid>/task or if this is a non-starter. If so
then I'll send an actual patch that also doesn't include
code-duplication to no end. ;)