linux-kernel - Re: [PATCH v1 1/1] at24: Drop of_match_ptr() and ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <f9b8acf8-7ed5-4d9f-84d1-acdbaa9e96d8@app.fastmail.com>
Date: Thu, 27 Feb 2025 09:18:30 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
 "Krzysztof Kozlowski" <krzk@...nel.org>
Cc: "Bartosz Golaszewski" <bartosz.golaszewski@...aro.org>,
 linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
 "Bartosz Golaszewski" <brgl@...ev.pl>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v1 1/1] at24: Drop of_match_ptr() and ACPI_PTR() protections

On Wed, Feb 26, 2025, at 15:18, Andy Shevchenko wrote:
> On Tue, Feb 25, 2025 at 06:21:29PM +0100, Krzysztof Kozlowski wrote:
>> On 25/02/2025 11:29, Arnd Bergmann wrote:
>> 
>> I tried to fix this in SPI, regulator and ASoC 2 years ago and Mark
>> rejected such approach of dropping ACPI/of_match_ptr. AFAIU, Mark wants
>> this to be fixed in more generic way, on the OF and ACPI common code,
>> not per driver.
>> 
>> SPI:
>> https://lore.kernel.org/all/7a65d775-cf07-4393-8b10-2cef4d5266ab@sirena.org.uk/
>> 
>> regulator:
>> https://lore.kernel.org/all/20230310214553.275450-1-krzysztof.kozlowski@linaro.org/
>> 
>> ASoC:
>> https://lore.kernel.org/all/20230310214333.274903-1-krzysztof.kozlowski@linaro.org/
>
> It was almost two years ago. Things may be changed :-)
> At least I have no impediments so far with converting drivers I'm supporting in
> the SPI. For ASoC there might be a new attempt by Cezary Rojewski in the future
> (he does some cleanups in that area, and we discussed cleaning up ACPI_PTR() at
>  minimum).

I skipped those three subsystems when I sent my backlog. Comparing
what I have left with the version from the patches above I see
that about 40% of the warnings in all three are already addressed
in the meantime, leaving just

 drivers/regulator/pbias-regulator.c   | 2 +-
 drivers/regulator/twl-regulator.c     | 2 +-
 drivers/regulator/twl6030-regulator.c | 2 +-
 drivers/spi/spi-armada-3700.c | 2 +-
 drivers/spi/spi-img-spfi.c    | 2 +-
 drivers/spi/spi-meson-spicc.c | 2 +-
 drivers/spi/spi-meson-spifc.c | 2 +-
 drivers/spi/spi-orion.c       | 2 +-
 drivers/spi/spi-pic32-sqi.c   | 2 +-
 drivers/spi/spi-pic32.c       | 2 +-
 drivers/spi/spi-rockchip.c    | 2 +-
 drivers/spi/spi-s3c64xx.c     | 2 +-
 drivers/spi/spi-st-ssc4.c     | 2 +-
 sound/soc/amd/acp3x-rt5682-max9836.c | 2 +-
 sound/soc/atmel/sam9x5_wm8731.c      | 2 +-
 sound/soc/codecs/rt1318.c            | 6 ++----
 sound/soc/codecs/rt5514-spi.c        | 2 +-
 sound/soc/qcom/lpass-sc7280.c        | 2 +-
 sound/soc/samsung/aries_wm8994.c     | 2 +-

I send everything else that I have to address the warnings, and
they are slowly making their way into the tree, as of today the
remaining ones are

 drivers/char/apm-emulation.c              | 5 ++---
 drivers/char/tpm/tpm_ftpm_tee.c           | 2 +-
 drivers/comedi/drivers/ni_atmio.c         | 2 +-
 drivers/dma/img-mdc-dma.c                 | 2 +-
 drivers/fpga/versal-fpga.c                | 2 +-
 drivers/input/touchscreen/stmpe-ts.c      | 2 +-
 drivers/mux/adg792a.c                     | 2 +-
 drivers/net/ethernet/apm/xgene-v2/main.c  | 4 +---
 drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +-
 drivers/rtc/rtc-fsl-ftm-alarm.c           | 2 +-
 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c    | 2 +-
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c    | 2 +-
 drivers/tty/serial/amba-pl011.c           | 6 +++---
 drivers/tty/serial/ma35d1_serial.c        | 2 +-

and I'm optimistic about most of them making it into the
next merge window. Once few enough are left, I can send
it again as a series that turns on the warning by default
and hopefully by that time we can wear down Mark enough
that he takes the patches even if he still disagrees ;-)

      Arnd