linux-kernel - [PATCH v4 0/2] Enable support for error detection in CSI2RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250227082920.744908-1-y-abhilashchandra@ti.com>
Date: Thu, 27 Feb 2025 13:59:18 +0530
From: Yemike Abhilash Chandra <y-abhilashchandra@...com>
To: <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
CC: <mripard@...nel.org>, <mchehab@...nel.org>, <jai.luthra@...ux.dev>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <devarsht@...com>, <vaishnav.a@...com>, <r-donadkar@...com>,
        <u-kumar1@...com>, <y-abhilashchandra@...com>
Subject: [PATCH v4 0/2] Enable support for error detection in CSI2RX

This patch series enables the csi2rx_err_irq interrupt to record any errors
that occur during streaming. It also adds support for the VIDIOC_LOG_STATUS
ioctl, which outputs the current device status to the kernel log.

The IRQ handler records any errors encountered during streaming.
Additionally, VIDIOC_LOG_STATUS can be invoked from user space to retrieve
the latest status.

Changelog:

Changes in v4:
- Add flexibility in DT bindings
- Drop the ACK from Krzysztof, since there is change in bindings
- Use dev_name(&pdev->dev) while requesting the IRQ handler
- Fix minor issues such as avoiding magic numbers, splitting long lines
  of code and removing extra spaces
- Make some minor changes in the commit messages.

The major update is about adding flexibilty in the bindings, since this
driver is shared by multiple vendors. The detailed discussion regarding
this can be found here [1].
[1]: https://lore.kernel.org/all/3fzkpcdjsthw5lbajxp6zyiyejo45rcgt3gwjfu2bub3v3acpa@kow5blexev5u/


Changes in v3:
- Address Krzysztof's review comment to drop minItems from the bindings.
- Collect Acked-by from Krzysztof.
- Address Jai's review comment to enable FIFO overflow bits in the mask 
  only for the source pads that have an active remote.
- Drop TI-specific interrupt and have support for only two interrupts 
  that are common across all vendors.
- Address Changhuang's review to use pdev directly to get the interrupt.
- Set the interrupt mask register only if the interrupt is defined in the DT.

V3: https://lore.kernel.org/all/20250221120337.3920874-1-y-abhilashchandra@ti.com/

Yemike Abhilash Chandra (2):
  dt-bindings: media: cdns,csi2rx.yaml: Add optional interrupts for
    cdns-csi2rx
  media: cadence: csi2rx: Enable csi2rx_err_irq interrupt and add
    support for VIDIOC_LOG_STATUS

 .../bindings/media/cdns,csi2rx.yaml           |  10 ++
 drivers/media/platform/cadence/cdns-csi2rx.c  | 129 ++++++++++++++++++
 2 files changed, 139 insertions(+)

-- 
2.34.1