linux-kernel - Re: [PATCH RESEND v2] Documentation/no_hz: Remove description that states boot CPU cannot be nohz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8ArXtTa8zAZDCtK@gmail.com>
Date: Thu, 27 Feb 2025 10:07:42 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Krishanth Jagaduri <Krishanth.Jagaduri@...y.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Jonathan Corbet <corbet@....net>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	Atsushi Ochiai <Atsushi.Ochiai@...y.com>,
	Daniel Palmer <Daniel.Palmer@...y.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Chris von Recklinghausen <crecklin@...hat.com>,
	Phil Auld <pauld@...hat.com>,
	Frederic Weisbecker <frederic@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH RESEND v2] Documentation/no_hz: Remove description that
 states boot CPU cannot be nohz_full


* Krishanth Jagaduri <Krishanth.Jagaduri@...y.com> wrote:

> Hi,
> 
> Before kernel 6.9, Documentation/timers/no_hz.rst states that
> "nohz_full=" mask must not include the boot CPU, which is no longer
> true after commit 08ae95f4fd3b ("nohz_full: Allow the boot CPU to be
> nohz_full").
> 
> When trying LTS kernels between 5.4 and 6.6, we noticed we could use
> boot CPU as nohz_full but the information in the document was misleading.
> 
> This was fixed upstream by commit 5097cbcb38e6 ("sched/isolation: Prevent
> boot crash when the boot CPU is nohz_full").
> 
> While it fixes the document description, it also fixes issue introduced
> by another commit aae17ebb53cd ("workqueue: Avoid using isolated cpus'
> timers on queue_delayed_work").
> 
> It is unlikely that upstream commit as a whole will be backported to
> stable kernels which does not contain the commit that introduced the
> issue of boot crash when boot CPU is nohz_full.
> 
> Could we fix only the document portion in stable kernels 5.4+ that
> mentions boot CPU cannot be nohz_full?

So you are requesting a partial backport to -stable of the 
Documentation/timers/no_hz.rst chunk of 5097cbcb38e6?

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo

================={ partial backport of 5097cbcb38e6 }=================>
>From 5097cbcb38e6e0d2627c9dde1985e91d2c9f880e Mon Sep 17 00:00:00 2001
From: Oleg Nesterov <oleg@...hat.com>
Date: Thu, 11 Apr 2024 16:39:05 +0200
Subject: [PATCH] sched/isolation: Prevent boot crash when the boot CPU is
 nohz_full

Documentation/timers/no_hz.rst states that the "nohz_full=" mask must not
include the boot CPU, which is no longer true after:

  08ae95f4fd3b ("nohz_full: Allow the boot CPU to be nohz_full").

However after:

  aae17ebb53cd ("workqueue: Avoid using isolated cpus' timers on queue_delayed_work")

the kernel will crash at boot time in this case; housekeeping_any_cpu()
returns an invalid CPU number until smp_init() brings the first
housekeeping CPU up.

Change housekeeping_any_cpu() to check the result of cpumask_any_and() and
return smp_processor_id() in this case.

This is just the simple and backportable workaround which fixes the
symptom, but smp_processor_id() at boot time should be safe at least for
type == HK_TYPE_TIMER, this more or less matches the tick_do_timer_boot_cpu
logic.

There is no worry about cpu_down(); tick_nohz_cpu_down() will not allow to
offline tick_do_timer_cpu (the 1st online housekeeping CPU).

Fixes: aae17ebb53cd ("workqueue: Avoid using isolated cpus' timers on queue_delayed_work")
Reported-by: Chris von Recklinghausen <crecklin@...hat.com>
Signed-off-by: Oleg Nesterov <oleg@...hat.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Signed-off-by: Ingo Molnar <mingo@...nel.org>
Reviewed-by: Phil Auld <pauld@...hat.com>
Acked-by: Frederic Weisbecker <frederic@...nel.org>
Link: https://lore.kernel.org/r/20240411143905.GA19288@redhat.com
Closes: https://lore.kernel.org/all/20240402105847.GA24832@redhat.com/
---
 Documentation/timers/no_hz.rst |  7 ++-----
 1 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/Documentation/timers/no_hz.rst b/Documentation/timers/no_hz.rst
index f8786be15183..7fe8ef9718d8 100644
--- a/Documentation/timers/no_hz.rst
+++ b/Documentation/timers/no_hz.rst
@@ -129,11 +129,8 @@ adaptive-tick CPUs:  At least one non-adaptive-tick CPU must remain
 online to handle timekeeping tasks in order to ensure that system
 calls like gettimeofday() returns accurate values on adaptive-tick CPUs.
 (This is not an issue for CONFIG_NO_HZ_IDLE=y because there are no running
-user processes to observe slight drifts in clock rate.)  Therefore, the
-boot CPU is prohibited from entering adaptive-ticks mode.  Specifying a
-"nohz_full=" mask that includes the boot CPU will result in a boot-time
-error message, and the boot CPU will be removed from the mask.  Note that
-this means that your system must have at least two CPUs in order for
+user processes to observe slight drifts in clock rate.) Note that this
+means that your system must have at least two CPUs in order for
 CONFIG_NO_HZ_FULL=y to do anything for you.
 
 Finally, adaptive-ticks CPUs must have their RCU callbacks offloaded.