linux-kernel - Re: [PATCH 1/2] firmware: arm_ffa: Explicitly cast return value from FFA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174065123542.2364600.7340078100778272878.b4-ty@arm.com>
Date: Thu, 27 Feb 2025 10:14:57 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: linux-arm-kernel@...ts.infradead.org,
	Sudeep Holla <sudeep.holla@....com>
Cc: linux-kernel@...r.kernel.org,
	Andrei Homescu <ahomescu@...gle.com>
Subject: Re: [PATCH 1/2] firmware: arm_ffa: Explicitly cast return value from FFA_VERSION before comparison

On Fri, 21 Feb 2025 09:56:31 +0000, Sudeep Holla wrote:
> The return value ver.a0 is unsigned long type and FFA_RET_NOT_SUPPORTED
> is a negative value.
>
> Since the return value from the firmware can be just 32-bit even on
> 64-bit systems as FFA specification mentions it as int32 error code in
> w0 register, explicitly casting to s32 ensures correct sign interpretation
> when comparing against a signed error code FFA_RET_NOT_SUPPORTED.
>
> [...]

Applied to sudeep.holla/linux (for-next/ffa/updates), thanks!

[1/2] firmware: arm_ffa: Explicitly cast return value from FFA_VERSION before comparison
      https://git.kernel.org/sudeep.holla/c/cecf6a504137
[2/2] firmware: arm_ffa: Explicitly cast return value from NOTIFICATION_INFO_GET
      https://git.kernel.org/sudeep.holla/c/3e282f41585c

--
Regards,
Sudeep