linux-kernel - Re: [PATCH] ALSA: seq: seq_oss_event: fix inconsistent indenting warning in note_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frjz7ko8.wl-tiwai@suse.de>
Date: Thu, 27 Feb 2025 11:21:11 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Charles Han <hanchunchao@...pur.com>
Cc: <perex@...ex.cz>,
	<tiwai@...e.com>,
	<linux-sound@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: seq: seq_oss_event: fix inconsistent indenting warning in note_on_event()

On Thu, 27 Feb 2025 10:24:41 +0100,
Charles Han wrote:
> 
> Fix below inconsistent indenting smatch warning.
> smatch warnings:
> sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn: inconsistent indenting
> 
> Signed-off-by: Charles Han <hanchunchao@...pur.com>
> ---
>  sound/core/seq/oss/seq_oss_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c
> index 7b7c925dd3aa..9a42713c7bdd 100644
> --- a/sound/core/seq/oss/seq_oss_event.c
> +++ b/sound/core/seq/oss/seq_oss_event.c
> @@ -294,7 +294,7 @@ note_on_event(struct seq_oss_devinfo *dp, int dev, int ch, int note, int vel, st
>  				/* set volume to zero -- note off */
>  			//	type = SNDRV_SEQ_EVENT_NOTEOFF;
>  			//else
> -				if (info->ch[ch].vel)
> +			if (info->ch[ch].vel)
>  				/* sample already started -- volume change */
>  				type = SNDRV_SEQ_EVENT_KEYPRESS;
>  			else

I'd rather clean up the commented-out dead lines and fix the indent as
well.  The indent was because of the "else" line.

Care to resubmit with that?


thanks,

Takashi