linux-kernel - Re: [PATCH v2 5/6] spi: tegra210-quad: modify chip select (CS) deactivation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <msvqwjnj6gb3gpnqtev5ebc7fpriprc3blrsg4yhjrwul63dza@dd5pmpjr2gd3>
Date: Thu, 27 Feb 2025 11:46:49 +0100
From: Thierry Reding <thierry.reding@...il.com>
To: Vishwaroop A <va@...dia.com>
Cc: jonathanh@...dia.com, skomatineni@...dia.com, ldewangan@...dia.com, 
	broonie@...nel.org, linux-spi@...r.kernel.org, linux-tegra@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kyarlagadda@...dia.com, smangipudi@...dia.com
Subject: Re: [PATCH v2 5/6] spi: tegra210-quad: modify chip select (CS)
 deactivation

On Wed, Feb 12, 2025 at 02:46:50PM +0000, Vishwaroop A wrote:
> Modify the chip select (CS) deactivation and inter-transfer delay
> execution to be performed only during the DATA_TRANSFER phase when
> the cs_change flag is not set. This ensures proper CS handling and
> timing between transfers while eliminating redundant operations.
> 
> Fixes: 1b8342cc4a38 ("spi: tegra210-quad: combined sequence mode")
> 
> Signed-off-by: Vishwaroop A <va@...dia.com>
> ---
>  drivers/spi/spi-tegra210-quad.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c
> index 2d7a2e3da337..04f41e92c1e2 100644
> --- a/drivers/spi/spi-tegra210-quad.c
> +++ b/drivers/spi/spi-tegra210-quad.c
> @@ -1171,16 +1171,16 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi,
>  				ret = -EIO;
>  				goto exit;
>  			}
> -			if (!xfer->cs_change) {
> -				tegra_qspi_transfer_end(spi);
> -				spi_transfer_delay_exec(xfer);
> -			}
>  			break;
>  		default:
>  			ret = -EINVAL;
>  			goto exit;
>  		}
>  		msg->actual_length += xfer->len;
> +		if (!xfer->cs_change && transfer_phase == DATA_TRANSFER) {
> +			tegra_qspi_transfer_end(spi);
> +			spi_transfer_delay_exec(xfer);
> +		}
>  		transfer_phase++;

I'd prefer blank lines around the "if" block to make this less
cluttered, but since this was always like this, either way:

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)