linux-kernel - RE: [PATCH v3 13/13] arm64: defconfig: Enable Renesas RZ/T2H SoC option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB11492DBCAD461B83B3CBE75E68ACD2@TYCPR01MB11492.jpnprd01.prod.outlook.com>
Date: Thu, 27 Feb 2025 10:48:43 +0000
From: Thierry Bultel <thierry.bultel.yh@...renesas.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Geert Uytterhoeven
	<geert@...ux-m68k.org>
CC: "thierry.bultel@...atsea.fr" <thierry.bultel@...atsea.fr>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, Paul
 Barker <paul.barker.ct@...renesas.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 13/13] arm64: defconfig: Enable Renesas RZ/T2H SoC
 option

Thanks Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: jeudi 27 février 2025 10:43
> To: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Thierry Bultel <thierry.bultel.yh@...renesas.com>;
> thierry.bultel@...atsea.fr; linux-renesas-soc@...r.kernel.org; Paul Barker
> <paul.barker.ct@...renesas.com>; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v3 13/13] arm64: defconfig: Enable Renesas RZ/T2H SoC
> option
> 
> On 27/02/2025 10:24, Geert Uytterhoeven wrote:
> > Hi Krzysztof,
> >
> > On Wed, 26 Feb 2025 at 15:40, Krzysztof Kozlowski <krzk@...nel.org>
> wrote:
> >> On 26/02/2025 15:32, Thierry Bultel wrote:
> >>>> -----Original Message-----
> >>>> From: Krzysztof Kozlowski <krzk@...nel.org>
> >>>> Sent: mercredi 26 février 2025 15:22
> >>>> To: Thierry Bultel <thierry.bultel.yh@...renesas.com>;
> >>>> thierry.bultel@...atsea.fr
> >>>> Cc: linux-renesas-soc@...r.kernel.org; geert@...ux-m68k.org; Paul
> >>>> Barker <paul.barker.ct@...renesas.com>;
> >>>> linux-arm->kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> >>>> Subject: Re: [PATCH v3 13/13] arm64: defconfig: Enable Renesas
> >>>> RZ/T2H SoC option
> >>>>
> >>>> On 26/02/2025 14:09, Thierry Bultel wrote:
> >>>>> Selects support for RZ/T2H (aka r9a09g077), and SCI (serial)
> >>>>> specific code for it.
> >>>>>
> >>>>> Signed-off-by: Thierry Bultel <thierry.bultel.yh@...renesas.com>
> >>>>> Reviewed-by: Paul Barker <paul.barker.ct@...renesas.com>
> >>>>> ---
> >>>>
> >>>> You never responded to my comments at v1. So I asked at v2. Still no
> answer.
> >>>>
> >>>> That's v3 and still silence from your side.
> >>>
> >>> Yes, I understand your position and have added a paragraph at the
> >>> end of the cover letter about this point.
> >>
> >> We do no read cover letters, unless look for dependencies, so if you
> >> disagree with someone you ought to respond to the email directly. Not
> >> silently discard.
> >>
> >> You keep adding more and more symbols, so your "out of scope of this
> >> patchset" is no true. Otherwise every contributor will use exactly
> >> the same arguments - "not my problem".
> >>
> >> So again NAK because it is something ought to be finally fixed (and
> >> is not even tricky to, so I don't ask for impossible).
> >
> > Adding RAM to existing systems is usually quite hard ;-)
> >
> > Not all Renesas SoCs are used in systems with multi-GiBs of RAM, so
> > IMHO it is still valuable to have fine control over which SoCs are
> > supported by your kernel (and e.g. which large pin control tables are
> > included in your kernel image).
> 
> 
> This is fine, I am not against fine-grained SoC-enable options. However
> all your SoCs should be enabled by default (default y if ARCH_RENESAS or
> any other option which works for you) thus you won't be growing user-
> selectable choices.
> 
> Strictly speaking this still will be choice, because you need to trim
> config, but all people and all distros will just ignore it  and don't see
> it in defconfig.
> 

I understand.

All the ARCH_XXX SoC options are already under a menuconfig section, which
is defaulted to 'y' if ARCH_RENESAS.

So I guess that this simple additional change would make it:

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index 91a815e0a522..231880c21aa7 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -358,6 +358,7 @@ config ARCH_R9A09G057
 
 config ARCH_R9A09G077
        bool "ARM64 Platform support for RZ/T2H"
+       default y
        help
          This enables support for the Renesas RZ/T2H SoC variants.

Regards
Thierry

> >
> > Gr{oetje,eeting}s,
> >
> >                         Geert
> >
> 
> 
> Best regards,
> Krzysztof