linux-kernel - Re: [PATCH v7 07/10] arm64: dts: morello: Add support for common functionalities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8BHrrL0kXeBmRpx@bogus>
Date: Thu, 27 Feb 2025 11:08:30 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Vincenzo Frascino <vincenzo.frascino@....com>
Cc: <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Sudeep Holla <sudeep.holla@....com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liviu Dudau <liviu.dudau@....com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Russell King <linux@...linux.org.uk>, Will Deacon <will@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Jessica Clarke <jrtc27@...c27.com>
Subject: Re: [PATCH v7 07/10] arm64: dts: morello: Add support for common
 functionalities

On Fri, Feb 21, 2025 at 06:03:46PM +0000, Vincenzo Frascino wrote:
> The Morello architecture is an experimental extension to Armv8.2-A,
> which extends the AArch64 state with the principles proposed in
> version 7 of the Capability Hardware Enhanced RISC Instructions
> (CHERI) ISA.
> 
> The Morello Platform (soc) and the Fixed Virtual Platfom (fvp) share
> some functionalities that have conveniently been included in
> morello.dtsi to avoid duplication.
> 
> Introduce morello.dtsi.
> 
> Note: Morello fvp will be introduced with a future patch series.
> 
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> ---
>  arch/arm64/boot/dts/arm/morello.dtsi | 323 +++++++++++++++++++++++++++
>  1 file changed, 323 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/arm/morello.dtsi
> 
> diff --git a/arch/arm64/boot/dts/arm/morello.dtsi b/arch/arm64/boot/dts/arm/morello.dtsi
> new file mode 100644
> +
> +		gic: interrupt-controller@...10000 {
> +			compatible = "arm,gic-v3";
> +			reg = <0x0 0x30000000 0x0 0x10000>,	/* GICD */
> +			      <0x0 0x300c0000 0x0 0x80000>;	/* GICR */

[...]

> +
> +
> +		sram: sram@...00000 {
> +			compatible = "mmio-sram";
> +			reg = <0x0 0x06000000 0x0 0x8000>;
> +			ranges = <0 0x0 0x06000000 0x8000>;
> +

[...]

Not sure if you are not seeing these warnings from DTC. Looks pretty clear
to me. May be you missed or using some old DTC. I don't know why though.
If you agree, I can patch it up with below patch and no need to repost:

morello.dtsi:227.38-272.5: Warning (simple_bus_reg): /soc/interrupt-controller@...10000: simple-bus unit address format error, expected "30000000"
morello.dtsi:296.23-313.5: Warning (simple_bus_reg): /soc/sram@...00000: simple-bus unit address format error, expected "6000000"
morello.dtsi:227.38-272.5: Warning (simple_bus_reg): /soc/interrupt-controller@...10000: simple-bus unit address format error, expected "30000000"
morello.dtsi:296.23-313.5: Warning (simple_bus_reg): /soc/sram@...00000: simple-bus unit address format error, expected "6000000"

Regards,
Sudeep

-->8

diff --git i/arch/arm64/boot/dts/arm/morello.dtsi w/arch/arm64/boot/dts/arm/morello.dtsi
index e35e5e482720..0bab0b3ea969 100644
--- i/arch/arm64/boot/dts/arm/morello.dtsi
+++ w/arch/arm64/boot/dts/arm/morello.dtsi
@@ -224,7 +224,7 @@ uart0: serial@...00000 {
                        status = "disabled";
                };

-               gic: interrupt-controller@...10000 {
+               gic: interrupt-controller@...00000 {
                        compatible = "arm,gic-v3";
                        reg = <0x0 0x30000000 0x0 0x10000>,     /* GICD */
                              <0x0 0x300c0000 0x0 0x80000>;     /* GICR */
@@ -293,7 +293,7 @@ mailbox: mhu@...00000 {
                        clock-names = "apb_pclk";
                };

-               sram: sram@...00000 {
+               sram: sram@...0000 {
                        compatible = "mmio-sram";
                        reg = <0x0 0x06000000 0x0 0x8000>;
                        ranges = <0 0x0 0x06000000 0x8000>;