linux-kernel - Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB95974209DC2F3AD757EBE40CB8CD2@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Thu, 27 Feb 2025 11:21:18 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: "pmladek@...e.com" <pmladek@...e.com>, "rostedt@...dmis.org"
	<rostedt@...dmis.org>, "andriy.shevchenko@...ux.intel.com"
	<andriy.shevchenko@...ux.intel.com>, "linux@...musvillemoes.dk"
	<linux@...musvillemoes.dk>, "senozhatsky@...omium.org"
	<senozhatsky@...omium.org>, "corbet@....net" <corbet@....net>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "apw@...onical.com"
	<apw@...onical.com>, "joe@...ches.com" <joe@...ches.com>,
	"dwaipayanray1@...il.com" <dwaipayanray1@...il.com>,
	"lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>,
	"sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
	"christian.koenig@....com" <christian.koenig@....com>
CC: "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>, Hector
 Martin <marcan@...can.st>, "linux@...linux.org.uk" <linux@...linux.org.uk>,
	"asahi@...ts.linux.dev" <asahi@...ts.linux.dev>, Sven Peter
	<sven@...npeter.dev>, Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by
 extending %p4cc



> On 24 Feb 2025, at 9:47 PM, Aditya Garg <gargaditya08@...e.com> wrote:
> 
> I request the printk maintainers for their views on whether if they are ok with the sparse errors in this original patch.

FWIW, I read a bit about FOURCC and also investigated the cpu_to_le32 and similar macros. I think the v4 I sent should work well, without the sparse warnings. I've also made the v4 separate from the DRM patch set, so as to avoid multiple tree complications and hindering the DRM driver upstream process. For now %p4cc was the best format helper I could find upstream, but I would prefer using %p4cl (little endian) instead for appletbdrm. And this patch imo is needed simply because we need better format helpers, rather than using workarounds to swap bits and using other format helpers.