linux-kernel - Re: [PATCH 1/6] Change inode_operations.mkdir to return struct dentry *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250227-narzissen-haifisch-2bf97aeb50d8@brauner>
Date: Thu, 27 Feb 2025 12:34:53 +0100
From: Christian Brauner <brauner@...nel.org>
To: NeilBrown <neilb@...e.de>
Cc: Christian Brauner <brauner@...nel.org>,
	Chuck Lever <chuck.lever@...cle.com>,
	Jeff Layton <jlayton@...nel.org>,
	Trond Myklebust <trondmy@...nel.org>,
	Anna Schumaker <anna@...nel.org>,
	linux-nfs@...r.kernel.org,
	Ilya Dryomov <idryomov@...il.com>,
	Xiubo Li <xiubli@...hat.com>,
	ceph-devel@...r.kernel.org,
	Miklos Szeredi <miklos@...redi.hu>,
	linux-fsdevel@...r.kernel.org,
	Richard Weinberger <richard@....at>,
	Anton Ivanov <anton.ivanov@...bridgegreys.com>,
	Johannes Berg <johannes@...solutions.net>,
	linux-um@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 1/6] Change inode_operations.mkdir to return struct dentry *

On Thu, 27 Feb 2025 12:32:53 +1100, NeilBrown wrote:
> Some filesystems, such as NFS, cifs, ceph, and fuse, do not have
> complete control of sequencing on the actual filesystem (e.g.  on a
> different server) and may find that the inode created for a mkdir
> request already exists in the icache and dcache by the time the mkdir
> request returns.  For example, if the filesystem is mounted twice the
> directory could be visible on the other mount before it is on the
> original mount, and a pair of name_to_handle_at(), open_by_handle_at()
> calls could instantiate the directory inode with an IS_ROOT() dentry
> before the first mkdir returns.
> 
> [...]

Applied to the vfs-6.15.async.dir branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.async.dir branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.async.dir

[1/6] Change inode_operations.mkdir to return struct dentry *
      https://git.kernel.org/vfs/vfs/c/10a5b48c3eeb
[2/6] hostfs: store inode in dentry after mkdir if possible.
      https://git.kernel.org/vfs/vfs/c/28d16ecaa2a8
[3/6] ceph: return the correct dentry on mkdir
      https://git.kernel.org/vfs/vfs/c/948ec6393e44
[4/6] fuse: return correct dentry for ->mkdir
      https://git.kernel.org/vfs/vfs/c/ef04f867aeb2
[5/6] nfs: change mkdir inode_operation to return alternate dentry if needed.
      https://git.kernel.org/vfs/vfs/c/5ca75f993a4a
[6/6] VFS: Change vfs_mkdir() to return the dentry.
      https://git.kernel.org/vfs/vfs/c/9cdf09f608d0