linux-kernel - Re: [PATCH v2 6/9] selftests/mm: Print some details when uffd-stress gets bad params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+i-1C2RFVZovrxjYGA3i6+vuizkMkr-OXr0bEOQrBqRoAqQ1Q@mail.gmail.com>
Date: Fri, 28 Feb 2025 13:47:36 +0100
From: Brendan Jackman <jackmanb@...gle.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Shuah Khan <shuah@...nel.org>
Cc: Dev Jain <dev.jain@....com>, linux-mm@...ck.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/9] selftests/mm: Print some details when uffd-stress
 gets bad params

On Fri, 21 Feb 2025 at 19:26, Brendan Jackman <jackmanb@...gle.com> wrote:
>         nr_pages_per_cpu = bytes / page_size / nr_threads;
>         if (!nr_pages_per_cpu) {
> -               _err("invalid MiB");
> +               _err("pages_per_cpu = 0, cannot test (%lu / %lu / %lu)",
> +                       nr_pages_per_cpu, bytes, page_size, nr_threads);

Ugh, this is garbage, wrong number of args for the format string.

I think I originally had %d instead of 0, then changed and didn't
notice I broke it because it doesn't actually cause the overall
kselftests build to fail. I'll need to find a way to update my scripts
to detect that.