linux-kernel - Re: [PATCH 2/2] regulator: adp5055: Add driver for adp5055

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61fe771b-befd-42b5-9f0d-7bad03c0b044@sirena.org.uk>
Date: Fri, 28 Feb 2025 13:05:36 +0000
From: Mark Brown <broonie@...nel.org>
To: "Torreno, Alexis Czezar" <AlexisCzezar.Torreno@...log.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/2] regulator: adp5055: Add driver for adp5055

On Fri, Feb 28, 2025 at 04:01:37AM +0000, Torreno, Alexis Czezar wrote:

> > You've open coded the operations instead of using the framework helpers, you
> > shouldn't need to anything other than supply data here.

> I did code this similar to the helper functions like regulator_enable_regmap.

Yes, that's the problem - you shouldn't be copying them at all.

> if having both gpio and register enable isn't that common, I guess it's an option 
> to remove the gpios and stay purely software

It's extremely common to have the option of choosing between a register
and a GPIO, that should just work with the framework code - we should
use the GPIO over the register if it's available.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)