linux-kernel - Re: [v3 PATCH] crypto: lzo - Fix compression buffer overrun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250228132111.GG5777@suse.cz>
Date: Fri, 28 Feb 2025 14:21:11 +0100
From: David Sterba <dsterba@...e.cz>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Nitin Gupta <nitingupta910@...il.com>,
	Richard Purdie <rpurdie@...nedhand.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	"Markus F.X.J. Oberhumer" <markus@...rhumer.com>,
	Dave Rodgman <dave.rodgman@....com>
Subject: Re: [v3 PATCH] crypto: lzo - Fix compression buffer overrun

On Thu, Feb 27, 2025 at 05:04:46PM +0800, Herbert Xu wrote:
> Unlike the decompression code, the compression code in LZO never
> checked for output overruns.  It instead assumes that the caller
> always provides enough buffer space, disregarding the buffer length
> provided by the caller.
> 
> Add a safe compression interface that checks for the end of buffer
> before each write.  Use the safe interface in crypto/lzo.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Thanks.

Reviewed-by: David Sterba <dsterba@...e.com>