linux-kernel - Re: [usb-storage] [PATCH v3 0/9] usb: storage: Mark various arrays as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17654d89-a9f3-478b-90d5-0bc9ab838739@rowland.harvard.edu>
Date: Fri, 28 Feb 2025 10:21:19 -0500
From: Alan Stern <stern@...land.harvard.edu>
To: j.ne@...teo.net
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	linux-kernel@...r.kernel.org
Subject: Re: [usb-storage] [PATCH v3 0/9] usb: storage: Mark various arrays
 as const

On Fri, Feb 28, 2025 at 04:11:15PM +0100, 'Jonathan Neuschäfer via B4 Relay' via USB Mass Storage on Linux wrote:
> While reading code, I noticed that some arrays in USB mass storage
> drivers are declared static but not const, even though they are not
> modified. This patchset marks them const.
> 
> All patches were compile-tested.
> 
> Signed-off-by: Jonathan Neuschäfer <j.ne@...teo.net>
> ---
> Changes in v3:
> - Elaborate *why* const is a good idea
> - Link to v2: https://lore.kernel.org/r/20250226-misc-const-v2-0-ab655a4a29cc@posteo.net
> 
> Changes in v2:
> - Add new patches 2-9
> - Use consistent authorship information
> - Link to v1: https://lore.kernel.org/r/20250225-misc-const-v1-1-121ff3b86437@posteo.net
> 
> ---
> Jonathan Neuschäfer (9):
>       usb: storage: jumpshot: Use const for constant arrays
>       usb: storage: transport: Use const for constant array
>       usb: storage: alauda: Use const for card ID array
>       usb: storage: datafab: Use const for constant arrays
>       usb: storage: initializers: Use const for constant array
>       usb: storage: realtek_cr: Use const for constant arrays
>       usb: storage: sddr09: Use const for constant arrays
>       usb: storage: sddr55: Use const for constant arrays
>       usb: storage: shuttle_usbat: Use const for constant array
> 
>  drivers/usb/storage/alauda.c        |  8 ++++----
>  drivers/usb/storage/datafab.c       | 14 +++++++-------
>  drivers/usb/storage/initializers.c  |  2 +-
>  drivers/usb/storage/jumpshot.c      | 10 +++++-----
>  drivers/usb/storage/realtek_cr.c    |  6 +++---
>  drivers/usb/storage/sddr09.c        | 14 +++++++-------
>  drivers/usb/storage/sddr55.c        |  4 ++--
>  drivers/usb/storage/shuttle_usbat.c |  2 +-
>  drivers/usb/storage/transport.c     |  2 +-
>  9 files changed, 31 insertions(+), 31 deletions(-)
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20240401-misc-const-e7b4cf20d5f9
> 
> Best regards,
> -- 
> Jonathan Neuschäfer <j.ne@...teo.net>

For all 9 patches:

Reviewed-by: Alan Stern <stern@...land.harvard.edu>