linux-kernel - Re: [PATCH 0/2] Describe the cameras in the PinePhone Pro dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0338826971bfdd5b771bc1c6ada795eb@manjaro.org>
Date: Fri, 28 Feb 2025 16:46:15 +0100
From: Dragan Simic <dsimic@...jaro.org>
To: Olivier Benjamin <olivier.benjamin@...tlin.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, oren@...moda.com, Ondrej Jirman <megi@....cz>
Subject: Re: [PATCH 0/2] Describe the cameras in the PinePhone Pro dts

Hello Olivier,

On 2025-02-28 16:19, Olivier Benjamin wrote:
> This series adds support for the Pine64 PinePhone Pro's rear and front
> cameras in Device Tree.
> This is based on some of Ondrej Jirman's patches hosted in his tree at
> https://codeberg.org/megi/linux, but I have also fully reviewed and
> re-written the code from the RK3399 datasheet, the PinePhone Pro
> schematic, and the IMX258-0AQH5 software reference manual.
> 
> I have tested these changes on my PinePhone Pro and am able to take
> photos from both cameras using libcamera's cam.
> 
> Signed-off-by: Olivier Benjamin <olivier.benjamin@...tlin.com>

I'm afraid that you haven't addressed the notes from the feedback
you received earlier? [*]  Also, this should be the v2 of the series,
which should contain "PATCH v2" in the patch subjects, and provide
a summary of changes in the cover letter.

Or, did you just resend the v1 by mistake?

[*] https://lore.kernel.org/linux-rockchip/5127541.31r3eYUQgx@phil/

> ---
> Olivier Benjamin (2):
>       arm64: dts: PinePhone Pro: describe I2c Bus 1 and IMX258 world 
> camera
>       arm64: dts: PinePhone Pro: describe the OV8858 user camera
> 
>  .../boot/dts/rockchip/rk3399-pinephone-pro.dts     | 138 
> +++++++++++++++++++++
>  1 file changed, 138 insertions(+)
> ---