linux-kernel - Re: [PATCH 5/7] MIPS: dec: Remove dec_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2502220019210.65342@angie.orcam.me.uk>
Date: Fri, 28 Feb 2025 16:01:16 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: WangYuli <wangyuli@...ontech.com>
cc: chenlinxuan@...ontech.com, guanwentao@...ontech.com, 
    linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org, 
    niecheng1@...ontech.com, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
    zhanjun@...ontech.com
Subject: Re: [PATCH 5/7] MIPS: dec: Remove dec_irq_dispatch()

On Tue, 18 Feb 2025, WangYuli wrote:

> Currently, dec_irq_dispatch() is exclusively invoked by int-handler.S.

 It always has been, since its inception, see commit 187933f23679 ("[MIPS] 
do_IRQ cleanup").

> Inline the do_IRQ call into int-handler.S to silence the compiler
> warning.

 Up to commit 8f99a16265353 ("MIPS: Tracing: Add IRQENTRY_EXIT section for 
MIPS") `do_IRQ' used to be a macro, that's why.  At the time `do_IRQ' was 
converted to a macro `dec_irq_dispatch' was created and previously this 
place used to call `do_IRQ' too.

 It's always good finding out why things are as they are so as to make 
sure you haven't been missing something.  This cleanup should have been 
made along with commit 8f99a16265353, so it's pretty old a technical debt 
being sorted here.

 Please add these findings to your commit description in v2.

 NB I'm off on holiday starting from tomorrow and I had issues with DEC 
hardware in my lab (now sorted, required a visit on site) so I couldn't 
get to your stuff sooner and also I won't be able to verify any of this 
until I'm back mid-March.

  Maciej