linux-kernel - Re: [PATCH] drm/radeon: Simplify maximum determination in radeon_uvd_calc_upll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <642022b6-ba71-407c-99d0-fffb58df2be7@gmx.de>
Date: Fri, 28 Feb 2025 18:49:12 +0100
From: Natalie Vock <natalie.vock@....de>
To: Markus Elfring <Markus.Elfring@....de>, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Qasim Ijaz <qasdev00@...il.com>
Subject: Re: [PATCH] drm/radeon: Simplify maximum determination in
 radeon_uvd_calc_upll_dividers()

On 28.02.25 17:36, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 28 Feb 2025 17:32:45 +0100
>
> Replace nested max() calls by single max3() call in this
> function implementation.
>
> This issue was transformed by using the Coccinelle software.

How about something like "this change was made" or "this code was
transformed"? Coccinelle didn't transform the issue, it transformed the
code to solve the issue.

Cheers,
Natalie

>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>   drivers/gpu/drm/radeon/radeon_uvd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
> index 058a1c8451b2..ded5747a58d1 100644
> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
> @@ -961,7 +961,7 @@ int radeon_uvd_calc_upll_dividers(struct radeon_device *rdev,
>   	unsigned optimal_score = ~0;
>
>   	/* loop through vco from low to high */
> -	vco_min = max(max(vco_min, vclk), dclk);
> +	vco_min = max3(vco_min, vclk, dclk);
>   	for (vco_freq = vco_min; vco_freq <= vco_max; vco_freq += 100) {
>
>   		uint64_t fb_div = (uint64_t)vco_freq * fb_factor;
> --
> 2.48.1
>