linux-kernel - Re: [PATCH] netfilter: Make xt_cgroup independent from net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <osn82ro6-08p7-q1so-r050-7poq60803250@vanv.qr>
Date: Fri, 28 Feb 2025 19:11:34 +0100 (CET)
From: Jan Engelhardt <ej@...i.de>
To: Michal Koutný <mkoutny@...e.com>
cc: netfilter-devel@...r.kernel.org, coreteam@...filter.org, 
    netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
    Pablo Neira Ayuso <pablo@...filter.org>, 
    Jozsef Kadlecsik <kadlec@...filter.org>, 
    "David S . Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
    Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
    cgroups@...r.kernel.org
Subject: Re: [PATCH] netfilter: Make xt_cgroup independent from net_cls


On Friday 2025-02-28 17:52, Michal Koutný wrote:
>@@ -23,6 +23,14 @@ MODULE_DESCRIPTION("Xtables: process control group matching");
> MODULE_ALIAS("ipt_cgroup");
> MODULE_ALIAS("ip6t_cgroup");
> 
>+static bool possible_classid(u32 classid)
>+{
>+	if (!IS_ENABLED(CONFIG_CGROUP_NET_CLASSID) && classid > 0)
>+		return false;
>+	else
>+		return true;
>+}

This has quite the potential for terseness ;-)

{
	return IS_ENABLED(CONFIG_CGROUP_NET_CLASSID) || classid == 0;
}