linux-kernel - Re: [PATCH -next] mmc: atmel-mci: Add missing clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1a9fc41-35df-4b30-83cc-5589a649c7ff@microchip.com>
Date: Fri, 28 Feb 2025 19:39:53 +0100
From: Aubin Constans <aubin.constans@...rochip.com>
To: Gu Bowen <gubowen5@...wei.com>, <ulf.hansson@...aro.org>
CC: <nicolas.ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
	<claudiu.beznea@...on.dev>, <ludovic.desroches@...rochip.com>,
	<linux-mmc@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <wangweiyang2@...wei.com>
Subject: Re: [PATCH -next] mmc: atmel-mci: Add missing clk_disable_unprepare()

On 25/02/2025 03:28, Gu Bowen wrote:
> The error path when atmci_configure_dma() set dma fails in atmci driver
> does not correctly disable the clock.
> Add the missing clk_disable_unprepare() to the error path for pair with
> clk_prepare_enable().
> 
> Fixes: 467e081d23e6 ("mmc: atmel-mci: use probe deferring if dma controller is not ready yet")
> Signed-off-by: Gu Bowen <gubowen5@...wei.com>

Acked-by: Aubin Constans <aubin.constans@...rochip.com>

> ---
>   drivers/mmc/host/atmel-mci.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index fc360902729d..24fffc702a94 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -2499,8 +2499,10 @@ static int atmci_probe(struct platform_device *pdev)
>          /* Get MCI capabilities and set operations according to it */
>          atmci_get_cap(host);
>          ret = atmci_configure_dma(host);
> -       if (ret == -EPROBE_DEFER)
> +       if (ret == -EPROBE_DEFER) {
> +               clk_disable_unprepare(host->mck);
>                  goto err_dma_probe_defer;
> +       }
>          if (ret == 0) {
>                  host->prepare_data = &atmci_prepare_data_dma;
>                  host->submit_data = &atmci_submit_data_dma;
> --
> 2.25.1
> 

Thank you for having identified and fixed this.