linux-kernel - Re: [PATCH v2] rust: adding UniqueRefCounted and UniqueRef types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <wDFD2QQ-TzRRhJJhPo1BisVzYy16SalSuoDJiYAb3sntdZaPfiVo1Q1DOVQqL873jaGY-ebJWMlyDERukXuFIg==@protonmail.internalid>
Date: Fri, 28 Feb 2025 18:41:57 +0000
From: Oliver Mangold <oliver.mangold@...me>
To: Andreas Hindborg <a.hindborg@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <benno.lossin@...ton.me>, Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2] rust: adding UniqueRefCounted and UniqueRef types

On 250228 1929, Andreas Hindborg wrote:
> 
> I would suggest splitting out the use case from the commit message:
> 
Yes, that makes sense. Will do.
> 
> The comments after the --- will not got in the commit log, they are a
> message for the review process only.
> 
Ahhh. Honestly I'm not very familiar with the format-patch/am
method, yet. That was a gap in my understanding.
Thanks for pointing that out. Now everything makes sense.

On 250228 1033, Boqun Feng wrote:
> 
> Now as we cleared things, I want to make sure that it's clear that I
> would like to see the patch with examples in it.
>
That's fine. That's a reasonable request. Will do.
> 
> i.e. you can add some description after the "---" line, and that won't
> affect git to apply the patches. Usually people put changes between
> versions, and in this case since you just want to update a version that
> is not the final version, you can add some description about that there
> as well.
> 
Yes. I just learned that it's working like this. See above :)
> 
> Thanks! Again, sorry for not being clear in previous emails.
>
Don't worry.


Best,

Oliver