linux-kernel - Re: [PATCH v6 04/42] x86/resctrl: Use schema type to determine how to parse schema values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63bbb8d0-e4cb-424b-9693-b8159e5414a8@arm.com>
Date: Fri, 28 Feb 2025 19:50:34 +0000
From: James Morse <james.morse@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
 Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>,
 Shaopeng Tan <tan.shaopeng@...fujitsu.com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v6 04/42] x86/resctrl: Use schema type to determine how to
 parse schema values

Hi Reinette,

On 19/02/2025 21:52, Reinette Chatre wrote:
> On 2/7/25 10:17 AM, James Morse wrote:
>> Resctrl's architecture code gets to specify a function pointer that is
>> used when parsing schema entries. This is expected to be one of two
>> helpers from the filesystem code.
>>
>> Setting this function pointer allows the architecture code to change
>> the ABI resctrl presents to user-space, and forces resctrl to expose
>> these helpers.
>>
>> Instead, add a schema format enum to choose which schema parser to
>> use. This allows the helpers to be made static and the structs used
>> for passing arguments moved out of shared headers.

>> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
>> index 496ddcaa4ecf..aed231a6d30c 100644
>> --- a/include/linux/resctrl.h
>> +++ b/include/linux/resctrl.h
>> @@ -192,6 +191,16 @@ enum resctrl_scope {
>>  	RESCTRL_L3_NODE,
>>  };
>>  
>> +/**
>> + * enum resctrl_schema_fmt - The format user-space provides for a schema.
>> + * @RESCTRL_SCHEMA_BITMAP:	The schema is a bitmap in hex.
>> + * @RESCTRL_SCHEMA_RANGE:	The schema is a decimal number,
> 
> Nit: Please let sentence end with a period.

... me and my fat fingers ...


>> + */
>> +enum resctrl_schema_fmt {
>> +	RESCTRL_SCHEMA_BITMAP,
>> +	RESCTRL_SCHEMA_RANGE,
>> +};
>> +
>>  /**
>>   * struct rdt_resource - attributes of a resctrl resource
>>   * @rid:		The index of the resource


> | Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Thanks!

James