linux-kernel - Re: [PATCH v6 39/42] x86/resctrl: Split trace.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <674314d0-d480-4bce-b12d-72c3b9fed1c0@arm.com>
Date: Fri, 28 Feb 2025 19:53:59 +0000
From: James Morse <james.morse@....com>
To: Fenghua Yu <fenghuay@...dia.com>,
 Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
 Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>,
 Shaopeng Tan <tan.shaopeng@...fujitsu.com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v6 39/42] x86/resctrl: Split trace.h

Hi Fenghua, Reinette,

On 25/02/2025 04:36, Fenghua Yu wrote:
> * # Be careful, this email looks suspicious; * Out of Character: The sender is exhibiting
> a significant deviation from their usual behavior, this may indicate that their account
> has been compromised. Be extra cautious before opening links or attachments. *
> Hi, Reinette and James,
> 
> On 2/19/25 21:45, Reinette Chatre wrote:
>> Hi James,
>>
>> On 2/7/25 10:18 AM, James Morse wrote:
>>> trace.h contains all the tracepoints. After the move to /fs/resctrl, some
>>> of these will be left behind. All the pseudo_lock tracepoints remain part
>>> of the architecture. The lone tracepoint in monitor.c moves to /fs/resctrl.
>>>
>>> Split trace.h so that each C file includes a different trace header file.
>>> This means the trace header files are not modified when they are moved.

>> I did not investigate if this originates here or after the code move but
>> when compiling the series (after running the file move script) with W=1

> The issues happen after running the move script.
> 
> It's because no trace event is defined in fs/resctrl/pseudo_lock_trace.h or arch/x86/
> kernel/cpu/resctrl/monitor_trace.h.
> 
> One way to fix them is to add empty events in the trace files. But seems that may cause
> the script difficulty because it cannot handle empty events easily.
> 
> Another way is to remove the two files and their inclusions in .c files. Please see my
> comment and fix in patch #42.

Yup, I have a followup patch that does this:
https://web.git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/commit/?h=mpam/snapshot/v6.14-rc1&id=3d0430324a0c7e7ad765140f9e78a9a312a13573

I assumed this was harmless, evidently it has some way of upsetting kbuild.

I'll post the version with the followup patches so they can be reviewed and squashed together.


Thanks,

James