linux-kernel - Re: [PATCH v6 23/42] x86/resctrl: Add resctrl_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b410f04-4711-4e4c-a275-e823038ebfdf@arm.com>
Date: Fri, 28 Feb 2025 19:57:03 +0000
From: James Morse <james.morse@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
 Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>,
 Shaopeng Tan <tan.shaopeng@...fujitsu.com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v6 23/42] x86/resctrl: Add resctrl_arch_ prefix to pseudo
 lock functions

Hi Reinette,

On 20/02/2025 00:53, Reinette Chatre wrote:
> On 2/7/25 10:18 AM, James Morse wrote:
>> resctrl's pseudo lock has some copy-to-cache and measurement
>> functions that are micro-architecture specific.
>>
>> For example, pseudo_lock_fn() is not at all portable.
>>
>> Label these 'resctrl_arch_' so they stay under /arch/x86.
>> To expose these functions to the filesystem code they need an entry
>> in a header file, and can't be marked static.

>> -static int measure_l3_residency(void *_plr)
>> +int resctrl_arch_measure_l3_residency(void *_plr)
>>  {
>>  	struct pseudo_lock_region *plr = _plr;
>>  	struct residency_counts counts = {0};
>> @@ -1205,14 +1207,14 @@ static int pseudo_lock_measure_cycles(struct rdtgroup *rdtgrp, int sel)
>>  	plr->cpu = cpu;
>>  
>>  	if (sel == 1)
>> -		thread = kthread_run_on_cpu(measure_cycles_lat_fn, plr,
>> -					    cpu, "pseudo_lock_measure/%u");
>> +		thread = kthread_run_on_cpu(resctrl_arch_measure_cycles_lat_fn,
>> +					     plr, cpu, "pseudo_lock_measure/%u");
> 
> checkpatch.pl does not like this extra space that sneaked in.

Looks like I missed the step to re-check that after the rebase.


> With spacing fixed:
> | Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>


Thanks!

James