linux-kernel - Re: [PATCH 1/3] dt-bindings: dma: fsl-edma: increase maxItems of interrupts and interrupt-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8IWo2ssQEKHlujy@lizhi-Precision-Tower-5810>
Date: Fri, 28 Feb 2025 15:03:47 -0500
From: Frank Li <Frank.li@....com>
To: Conor Dooley <conor@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Peng Fan <peng.fan@....com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, imx@...ts.linux.dev,
	dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Joy Zou <joy.zou@....com>
Subject: Re: [PATCH 1/3] dt-bindings: dma: fsl-edma: increase maxItems of
 interrupts and interrupt-names

On Fri, Feb 28, 2025 at 06:13:50PM +0000, Conor Dooley wrote:
> On Fri, Feb 28, 2025 at 12:42:03PM -0500, Frank Li wrote:
> > From: Joy Zou <joy.zou@....com>
> >
> > The edma controller support optional error interrupt, so update interrupts
> > and interrupt-names's maxItems.
>
> This seems like something were you would know based on the soc (or
> compatible) whether or not 64 or 65 is the correct maximum for that
> device?

Not exactly, 64 channel is maxium value, which IP supportted. There are
difference instances in the same SOC. Some may only 31 dma channel, some
may only 12, some have 64. Each channel have one irqs and one shared err
irq.

Ideally it should be property 'dma-channels' + 1. But not sure if schema
can check such case.

Frank

>
> >
> > Signed-off-by: Joy Zou <joy.zou@....com>
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  Documentation/devicetree/bindings/dma/fsl,edma.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > index 4f925469533e7..900170b3606ef 100644
> > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > @@ -40,11 +40,11 @@ properties:
> >
> >    interrupts:
> >      minItems: 1
> > -    maxItems: 64
> > +    maxItems: 65
> >
> >    interrupt-names:
> >      minItems: 1
> > -    maxItems: 64
> > +    maxItems: 65
> >
> >    "#dma-cells":
> >      description: |
> >
> > --
> > 2.34.1
> >