linux-kernel - Re: [PATCH v4 1/2] dt-bindings: clock: add clock definitions and documentation for exynos7870 CMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174077726185.3730179.16075411217823279787.robh@kernel.org>
Date: Fri, 28 Feb 2025 15:14:21 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Kaustabh Chakraborty <kauschluss@...root.org>
Cc: Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
 Alim Akhtar <alim.akhtar@...sung.com>, 
 Michael Turquette <mturquette@...libre.com>, 
 Sylwester Nawrocki <s.nawrocki@...sung.com>, linux-clk@...r.kernel.org, 
 Krzysztof Kozlowski <krzk@...nel.org>, linux-samsung-soc@...r.kernel.org, 
 Chanwoo Choi <cw00.choi@...sung.com>, linux-arm-kernel@...ts.infradead.org, 
 linux-kernel@...r.kernel.org, Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: clock: add clock definitions and
 documentation for exynos7870 CMU


On Sat, 01 Mar 2025 01:08:15 +0530, Kaustabh Chakraborty wrote:
> Add unique identifiers for exynos7870 clocks for every bank. It adds all
> clocks of CMU_MIF, CMU_DISPAUD, CMU_G3D, CMU_ISP, CMU_MFCMSCL, and
> CMU_PERI. Document the devicetree bindings as well.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@...root.org>
> ---
>  .../bindings/clock/samsung,exynos7870-cmu.yaml     | 227 +++++++++++++++
>  include/dt-bindings/clock/samsung,exynos7870-cmu.h | 324 +++++++++++++++++++++
>  2 files changed, 551 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/samsung,exynos7870-cmu.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
 	 $id: http://devicetree.org/schemas/clock/samsung,exynos7870-clock.yaml
 	file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/samsung,exynos7870-cmu.yaml
Documentation/devicetree/bindings/clock/samsung,exynos7870-cmu.example.dts:18:18: fatal error: dt-bindings/clock/exynos7870.h: No such file or directory
   18 |         #include <dt-bindings/clock/exynos7870.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/clock/samsung,exynos7870-cmu.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1511: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250301-exynos7870-pmu-clocks-v4-1-0f3e73b10db7@disroot.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.