linux-kernel - Re: [PATCH] arm64: dts: ti: k3-j784s4-j742s2-main-common: Fix serdes_ln

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250228053321.pekdadgl4ebscsc2@uda0492258>
Date: Fri, 28 Feb 2025 11:03:21 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <j-choudhary@...com>,
        <rogerq@...nel.org>
CC: <stable@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <srk@...com>, <s-vadapalli@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-j742s2-main-common: Fix
 serdes_ln_ctrl reg-masks

On Thu, Feb 27, 2025 at 11:46:43AM +0530, Siddharth Vadapalli wrote:

Kindly ignore this patch. The register offsets should start from 0x40
since SERDES3 is not present in J784S4. I will post the v2 patch fixing
this.

Regards,
Siddharth.

> Commit under Fixes added the 'idle-states' property for SERDES4 lane muxing
> without defining the corresponding register offsets and masks for it in the
> 'mux-reg-masks' property within the 'serdes_ln_ctrl' node.
> 
> Fix this.
> 
> Fixes: 7287d423f138 ("arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux")
> Cc: stable@...r.kernel.org
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
> ---
> 
> Hello,
> 
> This patch is based on commit
> dd83757f6e68 Merge tag 'bcachefs-2025-02-26' of git://evilpiepirate.org/bcachefs
> of the master branch of Mainline Linux.
> 
> Regards,
> Siddharth.
> 
>  arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
> index 83bbf94b58d1..a5fefafcba74 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
> @@ -84,7 +84,9 @@ serdes_ln_ctrl: mux-controller@...0 {
>  					<0x10 0x3>, <0x14 0x3>, /* SERDES1 lane0/1 select */
>  					<0x18 0x3>, <0x1c 0x3>, /* SERDES1 lane2/3 select */
>  					<0x20 0x3>, <0x24 0x3>, /* SERDES2 lane0/1 select */
> -					<0x28 0x3>, <0x2c 0x3>; /* SERDES2 lane2/3 select */
> +					<0x28 0x3>, <0x2c 0x3>, /* SERDES2 lane2/3 select */
> +					<0x30 0x3>, <0x34 0x3>, /* SERDES4 lane0/1 select */
> +					<0x38 0x3>, <0x3c 0x3>; /* SERDES4 lane2/3 select */
>  			idle-states = <J784S4_SERDES0_LANE0_PCIE1_LANE0>,
>  				      <J784S4_SERDES0_LANE1_PCIE1_LANE1>,
>  				      <J784S4_SERDES0_LANE2_IP3_UNUSED>,
> -- 
> 2.34.1
>