linux-kernel - Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d085c34a-fdbf-4950-a2e3-b3d25a1c0145@kernel.org>
Date: Fri, 28 Feb 2025 07:56:52 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wilson Ding <dingwei@...vell.com>, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc: andrew@...n.ch, gregory.clement@...tlin.com,
 sebastian.hesselbarth@...il.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, p.zabel@...gutronix.de, salee@...vell.com,
 gakula@...vell.com
Subject: Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller
 node

On 27/02/2025 20:25, Wilson Ding wrote:
> Add the reset controller node as a sub-node to the system controller
> node.
> 
> Signed-off-by: Wilson Ding <dingwei@...vell.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> index 161beec0b6b0..c27058d1534e 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> @@ -226,6 +226,8 @@ CP11X_LABEL(rtc): rtc@...000 {
>  		CP11X_LABEL(syscon0): system-controller@...000 {
>  			compatible = "syscon", "simple-mfd";
>  			reg = <0x440000 0x2000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
>  
>  			CP11X_LABEL(clk): clock {

Wait, no unit address here.

>  				compatible = "marvell,cp110-clock";
> @@ -273,6 +275,12 @@ CP11X_LABEL(gpio2): gpio@140 {
>  					 <&CP11X_LABEL(clk) 1 17>;
>  				status = "disabled";
>  			};
> +
> +			CP11X_LABEL(swrst): reset-controller@268 {


So why here it appeared? This is wrong and not even necessary. Entire
child should be folded into parent, so finally you will fix the
incomplete parent compatible.



Best regards,
Krzysztof