linux-kernel - [v2] phy: starfive: jh7110-dphy-tx: Add missing clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250228073127.635755-1-changhuang.liang@starfivetech.com>
Date: Thu, 27 Feb 2025 23:31:27 -0800
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
	linux-kernel@...r.kernel.org,
	linux-phy@...ts.infradead.org,
	Keith Zhao <keith.zhao@...rfivetech.com>,
	Changhuang Liang <changhuang.liang@...rfivetech.com>
Subject: [v2] phy: starfive: jh7110-dphy-tx: Add missing clk_disable_unprepare()

Once the reset_control_deassert() fails, we need to run the missing
clk_disable_unprepare() before return in stf_dphy_init().

Fixes: d3ab79553308 ("phy: starfive: Add mipi dphy tx support")
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Closes: https://lore.kernel.org/r/202410310715.duo3ShR4-lkp@intel.com/
Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
Reviewed-by: Keith Zhao <keith.zhao@...rfivetech.com>
---

v2: Add Keith reviewed tag.

 drivers/phy/starfive/phy-jh7110-dphy-tx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/starfive/phy-jh7110-dphy-tx.c b/drivers/phy/starfive/phy-jh7110-dphy-tx.c
index c64d1c91b130..7b59496983d2 100644
--- a/drivers/phy/starfive/phy-jh7110-dphy-tx.c
+++ b/drivers/phy/starfive/phy-jh7110-dphy-tx.c
@@ -330,6 +330,7 @@ static int stf_dphy_init(struct phy *phy)

 	ret = reset_control_deassert(dphy->sys_rst);
 	if (ret) {
+		clk_disable_unprepare(dphy->txesc_clk);
 		dev_err(dphy->dev, "Failed to deassert sys_rst\n");
 		return ret;
 	}
--
2.25.1